Skip to content

Commit 0dc8177

Browse files
authored
fix(pprof): initialize framehop before signal sampling (#9612)
fix(pprof): pin upstream framehop initialization fix Pin pprof workspace-wide to 01cff82d containing tikv/pprof-rs#282. Initialize framehop before sampling instead of allocating and discovering shared libraries in the first SIGPROF handler. Regenerate the lockfile without unrelated dependency changes. Signed-off-by: Lei, HUANG <[email protected]>
1 parent 7df99f9 commit 0dc8177

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎Cargo.lock‎

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,10 @@ datafusion-pg-catalog = { git = "https://github.com/datafusion-contrib/datafusio
384384
arrow-pg = { git = "https://github.com/datafusion-contrib/datafusion-postgres.git", rev = "ffb14a52b3d7c7489559812e1ec38096f225ce93" }
385385
sqlparser = { git = "https://github.com/GreptimeTeam/sqlparser-rs.git", rev = "9e9019bb1c7040ed956f654e39378dd42ab17884" }
386386

387+
# pprof 0.15.0 initializes framehop inside SIGPROF; pin the unreleased fix
388+
# that initializes it before sampling. Remove once tikv/pprof-rs#282 is released.
389+
pprof = { git = "https://github.com/tikv/pprof-rs", rev = "01cff82dbe6fe110a707bf2b38d8ebb1d14a18f8" }
390+
387391
# Temporary: use the GreptimeTeam fork of tikv-jemalloc-sys embedding
388392
# jemalloc 5.3.1 + backport of 54f22c83 ("Initialize TSD tcache before
389393
# enabling it"), fixing the TSD/tcache enable-before-init reentrancy

0 commit comments

Comments
 (0)