Add metadata labels to all HorizontalPodAutoscaler resources #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature / metadata improvement
What this PR does / why we need it:
In charts/, all Kubernetes resources have metadata labels defined, except for all HorizontalPodAutoscaler resources, as illustrated in the following architecture diagrams generated with KubeDiagrams:
This should be an oversight, shouldn't it?
This PR adds metadata labels to all HorizontalPodAutoscaler resources, as illustrated in the following architecture diagrams generated with KubeDiagrams:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This PR does not change anything on how charts behave. This PR only fixes metadata labels.
Does this PR introduce a user-facing change?
No
Does this PR introduce new external dependencies?
No
Additional documentation: