fix: port-forward error logs failed to port forward (#9728)
#9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rTools#9728) * fix: port-forward error logs `failed to port forward` Reflect changes in `os.Process` introduced in Go 1.23 * use `reflect` to make it future proof(?) * Add safeguards to call FieldByName * Add basic test to getHandleFromProcess * Fix copyright year
|
Linter is failing because a new schema version was added after this commit was merged to main and the linter is looking for the files generated when that new schema version was added. Since this commit we're cherry picking doesn't have any config changes I think we should be OK to ignore the failure. Error in linter: |
Darien-Lin
approved these changes
Mar 19, 2025
Darien-Lin
merged commit d76dbab
into
GoogleContainerTools:release/v2.14
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failed to port forwardReflect changes in
os.Processintroduced in Go 1.23use
reflectto make it future proof(?)Add safeguards to call FieldByName
Add basic test to getHandleFromProcess
Fix copyright year