feat: support templating in diagnose command #9393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8758
Description
go template
engine to render the specified fields, supported fields are the same as other commands see templated fields ,enable-templating
in diagnose command, as this feature is a breaking change for users are keeping template place holder when using diagnose command.ko builder
as other command which replace{{.ENV
with{{
, that was for ko-skaffold templates compatibilities , but we've documented that for more than one year https://skaffold.dev/docs/builders/builder-types/ko/#build-flags.ENV
is not needed, so treating it as normal templated fields should be fine.Schema change
Follow-up Work
Alternative Solution
skaffold.yaml
->Skaffold.Configuration
struct