Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gcloud for authenticating to AR's *-docker.pkg.dev #7063

Closed
briandealwis opened this issue Jan 28, 2022 · 1 comment
Closed

Use gcloud for authenticating to AR's *-docker.pkg.dev #7063

briandealwis opened this issue Jan 28, 2022 · 1 comment
Labels
area/auth kind/feature-request priority/p1 High impact feature/bug. source/partnerships

Comments

@briandealwis
Copy link
Member

briandealwis commented Jan 28, 2022 •
edited
Loading

Skaffold has special case logic to try to use GGCR's gcloud-based authenticator for gcr.io and *.gcr.io. We should also do this for *-docker.pkg.dev. This will simplify life for Cloud Deploy users. (edit: this will only affect docker builds that use the docker daemon 😢 )

skaffold/pkg/skaffold/docker/authenticators.go

Lines 100 to 105 in a3164bb

// 3. Try gcloud for *.gcr.io
if registry == "gcr.io" || strings.HasSuffix(registry, ".gcr.io") {
if auth, err := google.NewGcloudAuthenticator(); err == nil {
return auth
}
}

This is similar to what GGCR does already for the google keychain.

(Perhaps we can just use this google keychain?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/auth kind/feature-request priority/p1 High impact feature/bug. source/partnerships
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briandealwis @renzodavid9