Support server_listener_resource_name_template#14
Conversation
|
I went with the assumption that since this bootstrap generator is meant to be used with TD as the control plane, we can hardcode the listener_name template and not give the option of overriding with a flag. Please let me know if you think otherwise. |
| GRPCServerResourceNameID string `json:"grpc_server_resource_name_id,omitempty"` | ||
| XdsServers []server `json:"xds_servers,omitempty"` | ||
| Node *node `json:"node,omitempty"` | ||
| CertificateProviders map[string]certificateProviderConfig `json:"certificate_providers,omitempty"` |
There was a problem hiding this comment.
The above 3 lines don't contain an actual change - just tab/whitespace changes?
There was a problem hiding this comment.
That's gofmts work.
|
Gentle ping ... |
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Since this changes all-at-once, we'll probably need to upgrade this in the test environment at the same time that gRPC java is upgraded.
@sanjaypujare FYI |
…mplate support (#25746) Related: * GoogleCloudPlatform/traffic-director-grpc-bootstrap#14 * grpc/grpc-java#7978
3 participants
No description provided.