Google checkstyle breaking changes only#865
Merged
Conversation
meltsufin
approved these changes
Jan 11, 2022
Member
meltsufin
left a comment
meltsufin
left a comment
There was a problem hiding this comment.
I see some reformatting in addition to the rename, but I guess it's OK if it's compatible with the Spring Code Sytle.
| map.put(JsonLayout.FORMATTED_MESSAGE_ATTR_NAME, formatMessage(event)); | ||
| } | ||
| add(JsonLayout.MESSAGE_ATTR_NAME, this.includeMessage, event.getMessage(), map); | ||
| add(JsonLayout.CONTEXT_ATTR_NAME, this.includeContextName, event.getLoggerContextVO().getName(), map); |
Member
There was a problem hiding this comment.
This looks like a reformat, but OK.
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Breaking API changes: * rename XCloudTraceIdExtractor to CloudTraceIdExtractor * rename MDC to Mdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for switching from Spring to Google checkstyle, several breaking changes are needed. These will not be backported to 2.x.
Breaking changes:
traceIdMDCFieldandspanIdMDCFieldin custom layouts totraceIdMdcFieldandspanIdMdcFieldrespectively.)