Exclude all attributes starting with "goog_" from outbound Pub/Sub headers #845
Merged
Exclude all attributes starting with "goog_" from outbound Pub/Sub headers #845
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
elefeint
approved these changes
Jan 7, 2022
Contributor
elefeint
left a comment
elefeint
left a comment
There was a problem hiding this comment.
Did you mean to upgrade SampleAppIntegrationTest in this PR, or is it accidental?
Contributor
Author
|
It is accidental...I upgraded the test and committed the change and then started working on this issue without creating a new branch. |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…aders (GoogleCloudPlatform#845) * migrating the test * Fixing issue GoogleCloudPlatform#776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new header pattern "GcpPubSubHeaders.CLIENT" in outboundHeaderPatterns to strip out all the headers starting with "googclient_" along with writing a unit test for the same.
Fix to the issue -> #776
(This PR also includes migration of "SampleAppIntegrationTest.java" to JUnit5")