Rename method to avoid confusing name clash with parent#815
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
meltsufin
approved these changes
Jan 3, 2022
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…latform#815) * rename method to avoid confusing name clash with parent * add tests * remove public modifier from tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Data added a new package-private method in v2.5.0 that clashes in name with
SpannerQueryMethod.getMethod(). Sonar had angry thoughts about this that came up when I set Spring Boot version to 2.5.x in this repo.This PR should fix Sonar's complaint about a confusing method name. Also, since this method never had any business being public, and because this is a breaking change anyhow, I've reduced visibility to package-private.