Skip to content

Fix Flaky Test ConverterAwareMappingSpannerEntityReaderTests#readNotFoundColumnTest#4212

Merged
jinseopkim0 merged 1 commit intoGoogleCloudPlatform:mainfrom
pem70:Fix-readNotFoundColumnTest
Nov 11, 2025
Merged

Fix Flaky Test ConverterAwareMappingSpannerEntityReaderTests#readNotFoundColumnTest#4212
jinseopkim0 merged 1 commit intoGoogleCloudPlatform:mainfrom
pem70:Fix-readNotFoundColumnTest

Conversation

@pem70
Copy link
Copy Markdown
Contributor

@pem70 pem70 commented Oct 24, 2025

Issue

Test ConverterAwareMappingSpannerEntityReaderTests#readNotFoundColumnTest is flaky. See #4211

Fix

This fix checks only the stable part of the error message instead of the full string. It keeps verifying that the expected exception is thrown while removing flakiness from variable details like column names or formatting.

@pem70 pem70 requested a review from a team as a code owner October 24, 2025 00:31
@pem70 pem70 marked this pull request as draft October 24, 2025 00:32
@pem70 pem70 force-pushed the Fix-readNotFoundColumnTest branch 4 times, most recently from 4dd7bd6 to 8e88791 Compare October 24, 2025 00:41
@pem70 pem70 force-pushed the Fix-readNotFoundColumnTest branch from 8e88791 to 09cc98f Compare October 24, 2025 00:43
@pem70 pem70 marked this pull request as ready for review October 24, 2025 00:44
Copy link
Copy Markdown
Contributor

@jinseopkim0 jinseopkim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jinseopkim0 jinseopkim0 merged commit fb932b7 into GoogleCloudPlatform:main Nov 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants