fix(parametermanager): fix invalid bean definition named 'clientFactory'#4127
Merged
jinseopkim0 merged 4 commits intoGoogleCloudPlatform:mainfrom Sep 11, 2025
Conversation
suvidha-malaviya
force-pushed
the
fix(issues-4117)-invalid-bean-definition
branch
from
a42c421 to
f83f800
Compare
suvidha-malaviya
changed the title
suvidha-malaviya
changed the title
suvidha-malaviya
force-pushed
the
fix(issues-4117)-invalid-bean-definition
branch
from
f83f800 to
5f23214
Compare
gptSanyam
reviewed
Sep 10, 2025
| @Bean | ||
| @ConditionalOnMissingBean | ||
| public SecretManagerServiceClientFactory clientFactory() { | ||
| public SecretManagerServiceClientFactory secretManagerClientFactory() { |
There was a problem hiding this comment.
This change is backwards incompatible, right?
If anyone is using the auto-configured bean ("clientFactory") then after this change that will result in error.
Contributor
Author
There was a problem hiding this comment.
Yes, this change is backward-incompatible. However, the impact should be minimal, as the auto-configured clientFactory bean was mainly introduced to support global with multi-regional functionality and is not expected to be directly used by most users.
There was a problem hiding this comment.
@jinseopkim0 What do you think about the bean name changes?
| void testParameterManagerDependencyWithoutConfigImportShouldNotCrash() { | ||
| contextRunner | ||
| .withConfiguration(AutoConfigurations.of(GcpSecretManagerAutoConfiguration.class)) | ||
| .run(ctx -> assertThat(ctx).hasSingleBean(ParameterManagerClientFactory.class)); |
There was a problem hiding this comment.
Let's assert that ctx has a bean for SecretManagerClientFactory.class as well - given that we are autoconfiguring SM beans as well.
Contributor
Author
There was a problem hiding this comment.
Added test case for this.
gptSanyam
approved these changes
Sep 11, 2025
jinseopkim0
approved these changes
Sep 11, 2025
blakeli0
pushed a commit
that referenced
this pull request
Sep 15, 2025
🤖 I have created a release *beep* *boop* --- ## [7.3.1](v7.3.0...v7.3.1) (2025-09-15) ### Bug Fixes * **deps:** update dependency com.google.cloud:libraries-bom to v26.68.0 ([#4136](#4136)) ([2335f17](2335f17)) * **deps:** update gapic-generator-java-bom.version to v2.62.1 ([#4135](#4135)) ([7010534](7010534)) * **parametermanager:** fix invalid bean definition named 'clientFactory' ([#4127](#4127)) ([1c98540](1c98540)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ry' (#4127) Issue: [#4117](#4117) Changes: - Make Parameter Manager as `optional dependency` in AutoConfigure module. - Changed the `clientFactory` bean name for both Secret Manager and Parameter Manager. - Added logic to resolve the registered bean in `spring.factories` only if the class is present in the classpath for Parameter Manager. - Added parameter manager module and starter module in `spring-cloud-gcp-dependencies`. Testing: - [x] Created project which uses secretManager - [x] Created project which uses parameterManager - [x] Created project which uses secretManager and parameterManager
jinseopkim0
added a commit
that referenced
this pull request
Sep 29, 2025
Backports the following PRs to 6.x: #3699, #3684, #4127 --------- Co-authored-by: suvidha-malaviya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #4117
Changes:
optional dependencyin AutoConfigure module.clientFactorybean name for both Secret Manager and Parameter Manager.spring.factoriesonly if the class is present in the classpath for Parameter Manager.spring-cloud-gcp-dependencies.Testing: