fix(codegen): update dependency string replacement#1420
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
zhumin8
approved these changes
Jan 4, 2023
Contributor
zhumin8
left a comment
zhumin8
left a comment
There was a problem hiding this comment.
Just dropping a note here to switch to snapshot version in future.
This needs to have RULES_JVM_EXTERNAL upgrade to 4.5.
diegomarquezp
approved these changes
Jan 5, 2023
diegomarquezp
pushed a commit
that referenced
this pull request
Jan 20, 2023
This goes together with googleapis/sdk-platform-java#1208 in switching generator dependency from spring-cloud-gcp-core to spring-cloud-gcp-autoconfigure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes together with googleapis/sdk-platform-java#1208 in switching dependency from
spring-cloud-gcp-coretospring-cloud-gcp-autoconfigure.BEGIN_COMMIT_OVERRIDE
chore(codegen): update dependency string replacement
END_COMMIT_OVERRIDE