Skip to content

fix(codegen): add logic to add spring deps to googleapis/WORKSPACE#1349

Merged
zhumin8 merged 1 commit intomainfrom
add-dep
Nov 21, 2022
Merged

fix(codegen): add logic to add spring deps to googleapis/WORKSPACE#1349
zhumin8 merged 1 commit intomainfrom
add-dep

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Nov 18, 2022

To account for changes in googleapis/sdk-platform-java#1046, Spring related dependencies needs to be added to WORKSPACE.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@emmileaf emmileaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhumin8 zhumin8 merged commit 2934d1f into main Nov 21, 2022
@zhumin8 zhumin8 deleted the add-dep branch November 21, 2022 15:51
zhumin8 added a commit that referenced this pull request Nov 21, 2022
typo in replacement string. `,` should be outside of quotes.
zhumin8 added a commit that referenced this pull request Nov 21, 2022
typo in replacement string. `,` should be outside of quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants