This repository was archived by the owner on Jul 18, 2024. It is now read-only.
feat: Enable general location support in the CLI#143
Merged
Conversation
Note that it currently does not work; the location needs to be fully supported first
The CLI will automatically find the DB url, regardless of region.
It has been moved to a separate PR.
To note, this change depends on #144 first being submitted
mctavish
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the user to specify an arbitrary region via the
--locationoption to theinitcommand. The--locationoption previously existed, however it only allowed the default value ofus-central1. While the URL of databases in different regions will have different naming conventions, the CLI already made no assumptions in this regard and no extra changes were required to find the DB URL to use. The changes were the following:initcommand no longer enforces the default ofus-central1for the--locationargument.initcommand when--locationis used.fixes #134
fixes #141