Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Adds PHP support to the VS Code Extension#140

Merged
mctavish merged 1 commit intoGoogleCloudPlatform:mainfrom
i6systems:add-php-support-to-extension
Jun 19, 2023
Merged

Adds PHP support to the VS Code Extension#140
mctavish merged 1 commit intoGoogleCloudPlatform:mainfrom
i6systems:add-php-support-to-extension

Conversation

@carlos-granados
Copy link
Copy Markdown
Contributor

This allows VS Code to set breakpoints in PHP files

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish
Copy link
Copy Markdown
Contributor

Oh. And though it isn't currently enforced, we're trying to make sure that change titles comply with https://www.conventionalcommits.org/en/v1.0.0/. In short, just prefix your change description with "feat: " for this sort of change.

@mctavish
Copy link
Copy Markdown
Contributor

Hi @carlos-granados

Please send a PR to https://github.com/googleapis/google-cloud-php with the contents of googleapis/google-cloud-php-debugger#4. I'd like the PR to come from you so that you get credit for your work.

@carlos-granados
Copy link
Copy Markdown
Contributor Author

I moved the PR to the parent repo as requested googleapis/google-cloud-php#6281

@mctavish
Copy link
Copy Markdown
Contributor

mctavish commented Jun 8, 2023

googleapis/google-cloud-php#6281 has been merged and released. This PR is unblocked now :)

@mctavish mctavish self-requested a review June 8, 2023 14:28
@mctavish mctavish merged commit bb6ed74 into GoogleCloudPlatform:main Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants