-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
An issue was filed in google-cloud-python related to usability issues with the google-cloud-speech sample located here.
Currently there are 2 imports in speech/snippets/transcribe_streaming_v2.py with similar names. SpeechClient and cloud_speech could be confusing to readers as they appear to be similar.
Right now we have
from google.cloud.speech_v2 import SpeechClient
from google.cloud.speech_v2.types import cloud_speech
Instead we could have
from google.cloud.speech_v2 import SpeechClient
from google.cloud.speech_v2.types import cloud_speech as cloud_speech_types
or this could also work
from google.cloud.speech_v2 import SpeechClient
from google.cloud.speech_v2 import StreamingRecognizeRequest
from google.cloud.speech_v2 import RecognitionConfig
from google.cloud.speech_v2 import StreamingRecognizeResponse
Metadata
Metadata
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.