Skip to content

feat!: Use poetry over pipenv #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
happyhuman merged 8 commits into from
Apr 11, 2022
Merged

feat!: Use poetry over pipenv #337

happyhuman merged 8 commits into from
Apr 11, 2022

Conversation

@adlersantos
Copy link
Member

@adlersantos adlersantos commented Apr 11, 2022 •
edited
Loading

Description

This PR uses poetry over pipenv for supporting multiple environments when developing either pipelines or documentation.

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have updated the README accordingly
    • I have added tests for the feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory
  • I'm adding/editing documentation
  • I'm submitting a bugfix
    • I have added tests to my bugfix (see the tests folder)
  • I'm refactoring or cleaning up some code

@adlersantos adlersantos requested a review from happyhuman April 11, 2022 03:05
@adlersantos adlersantos added revision: readme Improvements or additions to the README cleanup Cleanup or refactor code dependencies Dependency changes and updates labels Apr 11, 2022
@happyhuman happyhuman merged commit ca43066 into main Apr 11, 2022
@happyhuman happyhuman deleted the poetry branch April 11, 2022 17:39
@release-please release-please bot mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@happyhuman happyhuman happyhuman approved these changes

Assignees

No one assigned

Labels

cleanup Cleanup or refactor code dependencies Dependency changes and updates revision: readme Improvements or additions to the README

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adlersantos @happyhuman