Use a shorter timeout for the metadata endpoint#362
Merged
aabmass merged 2 commits intoGoogleCloudPlatform:mainfrom Dec 9, 2024
Merged
Use a shorter timeout for the metadata endpoint#362aabmass merged 2 commits intoGoogleCloudPlatform:mainfrom
aabmass merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Use a shorter timeout of 2 seconds instead of the read of 5 seconds to avoid blocking too much if the metadata server is not available. This makes the code behave more similar to the go one: https://github.com/googleapis/google-cloud-go/blob/main/compute/metadata/metadata.go#L65
Collaborator
|
/gcbrun |
aabmass
reviewed
Dec 6, 2024
...y-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_metadata.py
Show resolved
Hide resolved
aabmass
approved these changes
Dec 6, 2024
xrmx
changed the title
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a shorter timeout of 2 seconds for the connection before the 5 seconds read one to avoid blocking too much if the metadata server is not available.
This makes the code behave more similar to the go one: https://github.com/googleapis/google-cloud-go/blob/main/compute/metadata/metadata.go#L65