Map faas.* attributes to generic_task in resource mapping#273
Merged
dashpole merged 5 commits intoGoogleCloudPlatform:mainfrom Sep 28, 2023
Merged
Map faas.* attributes to generic_task in resource mapping#273dashpole merged 5 commits intoGoogleCloudPlatform:mainfrom
dashpole merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
dashpole
force-pushed
the
faas_to_generic_task
branch
4 times, most recently
from
c2757b2 to
0bebac5
Compare
Contributor
Author
|
Ideally: If a user sets a service.name, use that. Otherwise, fall back to faas.name. Options:
|
Contributor
Author
|
I've proposed option 2 in a design document. |
dashpole
force-pushed
the
faas_to_generic_task
branch
6 times, most recently
from
41279e6 to
4f2b35b
Compare
dashpole
force-pushed
the
faas_to_generic_task
branch
7 times, most recently
from
36d6119 to
f235f3b
Compare
dashpole
force-pushed
the
faas_to_generic_task
branch
from
f235f3b to
12131df
Compare
Contributor
Author
|
I think this is good to go @aabmass. |
aabmass
reviewed
Sep 21, 2023
dashpole
force-pushed
the
faas_to_generic_task
branch
from
528f845 to
4ea1d6d
Compare
This was referenced Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Question: should faas.* attributes take precedence over service.* attributes if they are present? If they do, it might break users who are currently using service.* attributes. If we don't, the default service (unknown) will take precedence over faas.name