Update OTLP Trace Example to use Auth Extension#391
Merged
psx95 merged 3 commits intoGoogleCloudPlatform:mainfrom Jan 31, 2025
Merged
Update OTLP Trace Example to use Auth Extension#391psx95 merged 3 commits intoGoogleCloudPlatform:mainfrom
psx95 merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
dashpole
approved these changes
Jan 31, 2025
aabmass
reviewed
Jan 31, 2025
examples/otlptrace/build.gradle
Outdated
Comment on lines
+30
to
+31
| // the shaded variant name is empty | ||
| implementation("${libraries.opentelemetry_gcp_auth_extension}:") |
Contributor
There was a problem hiding this comment.
🙈
Not sure if it's only .kts, but is there a way to pass named arguments so you could make the empty string more explicit?
Contributor
Author
There was a problem hiding this comment.
Yeah for some reason,
implementation group: 'io.opentelemetry.contrib', name: 'opentelemetry-gcp-auth-extension', version: '1.43.0-alpha', classifier: ''is not working.
I made a change that makes the intentional use of empty classifier more explicit. This is temporary and will be fixed in the next release of the auth extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the OTLP Trace example to use the GCP Auth Extension to export traces to GCP.