Make project compatible with Java 17#385
Merged
psx95 merged 1 commit intoGoogleCloudPlatform:mainfrom Dec 9, 2024
Merged
Conversation
Mockito 3.5.x is incompatible when building with Java 17, therefore an update to a more recent version of Mockito is required. There have been breaking changes in Mockito's releases which are difficult to point out. Some tests required code changes to make them compatible with these changes. Only breaking change that affected this codebase was the handling of static mocks.
jsuereth
approved these changes
Dec 9, 2024
dashpole
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mockito 3.5.x is incompatible when building with Java 17, therefore an update to a more recent version of Mockito is required. There have been breaking changes in Mockito's releases which are difficult to point out. Some tests required code changes to make them compatible with these changes.
Only breaking change that affected this codebase was the handling of static mocks.
This change only makes the project compatible with Java 17.
Mockito 3.x is also ~5 yrs old at this point.