Add new module for resource-detector support library#276
Merged
psx95 merged 26 commits intoGoogleCloudPlatform:mainfrom Jan 16, 2024
Merged
Add new module for resource-detector support library#276psx95 merged 26 commits intoGoogleCloudPlatform:mainfrom
psx95 merged 26 commits intoGoogleCloudPlatform:mainfrom
Conversation
psx95
force-pushed
the
refactor-resource-detector
branch
from
c9235af to
f4e1173
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
2 times, most recently
from
b0a0878 to
563ea05
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
2 times, most recently
from
2c2c1d6 to
f8b15ae
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
2 times, most recently
from
7ad60e9 to
eefad12
Compare
psx95
commented
Jan 3, 2024
psx95
force-pushed
the
refactor-resource-detector
branch
from
eefad12 to
3a48e94
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
from
3a48e94 to
27184e3
Compare
jsuereth
reviewed
Jan 4, 2024
jsuereth
reviewed
Jan 4, 2024
jsuereth
reviewed
Jan 5, 2024
|
|
||
| // Order of detection functions matters here | ||
| Stream<Function<EnvironmentVariables, Optional<SupportedPlatform>>> platforms = | ||
| Stream.of(detectGKE, detectGCR, detectGCF, detectGAE); |
Collaborator
There was a problem hiding this comment.
Shouldn't GCF be before GCR?
Contributor
Author
There was a problem hiding this comment.
I did not look at the spec again, but I was going by the code we already had - in which we checked for GCR before GCF.
Is there a reason why GCF should be checked before GCR ?
jsuereth
reviewed
Jan 5, 2024
psx95
force-pushed
the
refactor-resource-detector
branch
from
d9c39eb to
d3df7d6
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
from
d3df7d6 to
5c9500f
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
from
de8d26a to
8ab8080
Compare
psx95
force-pushed
the
refactor-resource-detector
branch
from
7e8e92d to
601b4f0
Compare
dashpole
approved these changes
Jan 9, 2024
psx95
force-pushed
the
refactor-resource-detector
branch
from
0c3035c to
4d577f0
Compare
Support library was using the same package as the detectors library. This rename would avoid potential conflicts and import issues.
SylvainJuge
approved these changes
Jan 15, 2024
psx95
force-pushed
the
refactor-resource-detector
branch
from
7b53df5 to
3ced0b9
Compare
These breaking chnages can be directly introduced when we contribute the resource detector upstream. This commit adds classes back and marks them deprecated to indicate to the users not to depend on them.
psx95
force-pushed
the
refactor-resource-detector
branch
from
3ced0b9 to
dccc767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates out resource detection module into a support-library (detector-resources-support) and a mapper (detector-resources).
The mapper uses the support-library to map OTel specific resources to GCP specific resources. The support-library contains logic to detect the GCP specific resources and provided appropriate attributes for the detected resource.
The logic split has been done keeping the following in mind -
Supports #266