just adding ':' for log consistency by congr · Pull Request #694 · GoogleCloudPlatform/nodejs-docs-samples

congr · 2018-07-23T01:49:31Z

No description provided.

googlebot · 2018-07-23T01:49:35Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

codecov · 2018-07-23T02:01:38Z

Codecov Report

Merging #694 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0db75...31cae9c. Read the comment docs.

congr · 2018-07-23T02:29:02Z

I signed it!

googlebot · 2018-07-23T02:29:05Z

CLAs look good, thanks!

* Update index.js * Clarify mocking comments (#682) * fix: just adding : for log consistency (#694) * Update index.js * Update index.js * Update index.js * Fix test

* translate document sample and test Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485 * remove comment Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf * lint Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d * batch translate document Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2 * batch translate document Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb * update year Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371 * refactor error handling Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e * refactor error handling Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1

🤖 I have created a release *beep* *boop* --- ## [3.4.0](googleapis/nodejs-dlp@v3.3.0...v3.4.0) (2022-03-25) ### Features * new Bytes and File types: POWERPOINT and EXCEL ([#693](googleapis/nodejs-dlp#693)) ([ed3dc42](googleapis/nodejs-dlp@ed3dc42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

just adding : for log consistency

31cae9c

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018

congr changed the title ~~just adding : for log consistency~~ just adding ':' for log consistency Jul 23, 2018

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2018

JustinBeckwith approved these changes Jul 23, 2018

View reviewed changes

JustinBeckwith merged commit 1845478 into GoogleCloudPlatform:master Jul 23, 2018

ace-n pushed a commit that referenced this pull request Jul 23, 2018

Make logging sample an HTTP function (#691)

1453f75

* Update index.js * Clarify mocking comments (#682) * fix: just adding : for log consistency (#694) * Update index.js * Update index.js * Update index.js * Fix test

snyk-bot mentioned this pull request May 26, 2021

[Snyk] Security upgrade got from 9.5.0 to 9.5.1 leejh3224/nodejs-docs-samples#333

Open

snyk-bot mentioned this pull request Jul 22, 2021

[Snyk] Security upgrade @google-cloud/trace-agent from 2.1.3 to 2.6.0 ninadhatkar/nodejs-docs-samples#114

Open

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore(samples): fix function name (#694)

c11cc67

This was referenced Nov 14, 2022

migrate code from googleapis/nodejs-compute #2846

Closed

migrate code from googleapis/nodejs-compute #2853

Merged

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 21, 2022

chore(samples): fix function name (#694)

7eb38ac

ace-n pushed a commit that referenced this pull request Nov 21, 2022

chore(samples): fix function name (#694)

c7ce39b

snyk-bot mentioned this pull request Dec 23, 2022

[Snyk] Fix for 4 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#374

Open

pedroarapua mentioned this pull request Dec 23, 2022

[Snyk] Fix for 4 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#375

Open

Shabirmean mentioned this pull request Feb 16, 2023

samples: migrate code from googleapis/nodejs-dlp #3035

Merged

pedroarapua mentioned this pull request Jun 21, 2023

[Snyk] Fix for 1 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#404

Open

This was referenced Jul 6, 2023

[Snyk] Security upgrade @google-cloud/logging-winston from 0.11.1 to 5.0.0 pedroarapua/nodejs-docs-samples-gcp#417

Open

[Snyk] Security upgrade @google-cloud/logging-winston from 0.11.1 to 5.0.0 pedroarapua/nodejs-docs-samples-gcp#421

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

just adding ':' for log consistency#694

just adding ':' for log consistency#694
JustinBeckwith merged 1 commit intoGoogleCloudPlatform:masterfrom
congr:patch-1

congr commented Jul 23, 2018

Uh oh!

googlebot commented Jul 23, 2018

Uh oh!

codecov Bot commented Jul 23, 2018 •

edited

Loading

Uh oh!

congr commented Jul 23, 2018

Uh oh!

googlebot commented Jul 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

congr commented Jul 23, 2018

Uh oh!

googlebot commented Jul 23, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

codecov Bot commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

congr commented Jul 23, 2018

Uh oh!

googlebot commented Jul 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 23, 2018 •

edited

Loading