Add Premium translation sample. #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace-n
approved these changes
Dec 15, 2016
Contributor
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM; I'm just nitpicking.
| return translate.translate(input, options) | ||
| .then((results) => { | ||
| let translations = results[0]; | ||
| translations = Array.isArray(translations) ? translations : [translations]; |
Contributor
There was a problem hiding this comment.
Nit: not that we should use it, but there's a library for this. 😛
Member
Author
There was a problem hiding this comment.
Personally, I feel that using a library for something like this is taking the Node.js "module all the things" too far...
Contributor
There was a problem hiding this comment.
I like the brevity/idiomaticity of arrify(...) vs. a ternary operator, but you're right in the sense that using it would add another dependency (= another potential point of failure).
jmdobry
force-pushed
the
translate-premium
branch
from
fb868dc to
5f367da
Compare
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.2](https://www.github.com/googleapis/nodejs-talent/compare/v3.0.1...v3.0.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#274](https://www.github.com/googleapis/nodejs-talent/issues/274)) ([a25c71f](https://www.github.com/googleapis/nodejs-talent/commit/a25c71ff62a46138e088f01d5b9cd8b165588bbd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.2](https://www.github.com/googleapis/nodejs-talent/compare/v3.0.1...v3.0.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#274](https://www.github.com/googleapis/nodejs-talent/issues/274)) ([a25c71f](https://www.github.com/googleapis/nodejs-talent/commit/a25c71ff62a46138e088f01d5b9cd8b165588bbd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 16, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
This was referenced Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.3.3...v2.3.4) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#272](https://www.github.com/googleapis/nodejs-datacatalog/issues/272)) ([62ffcc6](https://www.github.com/googleapis/nodejs-datacatalog/commit/62ffcc6fd9a5b68936a57c1ac5a041527e38fec3)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#274](https://www.github.com/googleapis/nodejs-datacatalog/issues/274)) ([3ebafcd](https://www.github.com/googleapis/nodejs-datacatalog/commit/3ebafcdbfaf50ff96f9d828e33cc355af33a7000)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.3.3...v2.3.4) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#272](https://www.github.com/googleapis/nodejs-datacatalog/issues/272)) ([62ffcc6](https://www.github.com/googleapis/nodejs-datacatalog/commit/62ffcc6fd9a5b68936a57c1ac5a041527e38fec3)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#274](https://www.github.com/googleapis/nodejs-datacatalog/issues/274)) ([3ebafcd](https://www.github.com/googleapis/nodejs-datacatalog/commit/3ebafcdbfaf50ff96f9d828e33cc355af33a7000)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.