Skip to content

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Sep 1, 2016

(I know we're planning to get rid of JSDoc comments, but I thought this was worth fixing before I included this sample on the docs.)

@jmdobry jmdobry merged commit 4d63879 into master Sep 1, 2016
@ace-n ace-n deleted the fix-typo branch September 1, 2016 21:28
grayside pushed a commit that referenced this pull request Oct 26, 2022
* Task with authentication sample

* Update region tags

* Linting error

* Small updates

* Add real service account to tests

* Update queue id
grayside pushed a commit that referenced this pull request Nov 3, 2022
* Task with authentication sample

* Update region tags

* Linting error

* Small updates

* Add real service account to tests

* Update queue id
NimJay pushed a commit that referenced this pull request Nov 9, 2022
Use new effective_severity field

fixes b/142836422
ace-n pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 11, 2022
NimJay pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 11, 2022
telpirion pushed a commit that referenced this pull request Nov 16, 2022
* Vision-GA - vision_localize_objects & vision_localize_object_gcs

* Vision-GA - README file updates

* Vision-GA - Fixes after review

* Vision-GA - Fixes after review
unforced pushed a commit that referenced this pull request Nov 17, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
kweinmeister pushed a commit that referenced this pull request Jan 11, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-retail/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants