Add OpenCensus sample code #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
fhinkel
reviewed
Feb 21, 2019
Contributor
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
Hi, can you provide tests please. Thanks
Contributor
Author
Done, can you please take a look again. Thanks |
Contributor
|
Thanks, we also need the .kokoro config files so the tests will be run. |
fhinkel
reviewed
Feb 26, 2019
|
|
||
| // The minimum reporting period for Stackdriver is 1 minute. | ||
| const exporter = new StackdriverStatsExporter({ | ||
| projectId: projectId, |
Contributor
There was a problem hiding this comment.
Is the projectId needed? Our client libraries hat the convention to use the GOOGLE_APPLICATION_CREDENTIALS implicitly and users should not be required to provide the project id.
Contributor
Author
There was a problem hiding this comment.
Yes, it is required. Will open an issue and modify example later. Is that ok?
fhinkel
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node version of https://github.com/GoogleCloudPlatform/golang-samples/pull/646/files.