Skip to content

Adding peered_network_ip_range field to google_cloudbuild_worker_pool #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
khalkie wants to merge 3 commits into from
Closed

Adding peered_network_ip_range field to google_cloudbuild_worker_pool #7335

khalkie wants to merge 3 commits into from

Conversation

@khalkie
Copy link
Member

@khalkie khalkie commented Feb 22, 2023 •
edited
Loading

Adding new field peered_network_ip_range to Google Cloud Build workerpool tests

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added `peered_network_ip_range` field to `google_cloudbuild_worker_pool` resource

@modular-magician
Copy link
Collaborator

modular-magician commented Feb 22, 2023

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

@modular-magician
Copy link
Collaborator

modular-magician commented Feb 22, 2023

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 160 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 9 files changed, 165 insertions(+), 71 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@khalkie khalkie mentioned this pull request Feb 22, 2023
Closed
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Feb 22, 2023

Tests analytics

Total tests: 2462
Passed tests 2205
Skipped tests: 255
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccCloudbuildWorkerPool_withNetwork

@modular-magician
Copy link
Collaborator

modular-magician commented Feb 22, 2023

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Debug log]

All tests passed
View the build log or the debug log for each test

@khalkie khalkie marked this pull request as ready for review February 22, 2023 13:07
@khalkie khalkie requested a review from a team as a code owner February 22, 2023 13:07
@melinath melinath self-assigned this Feb 23, 2023
@melinath
Copy link
Member

melinath commented Feb 23, 2023

Duplicate of #7276

@melinath melinath marked this as a duplicate of #7276 Feb 23, 2023
@melinath melinath closed this Feb 23, 2023
@melinath melinath mentioned this pull request Feb 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath Awaiting requested review from melinath

Assignees

@melinath melinath

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khalkie @modular-magician @melinath