feat: Add support for deletion_policy on shared vpc service project #7283

NexusNull · 2023-02-14T12:28:56Z

Signed-off-by: NexusNull [email protected]

part of: hashicorp/terraform-provider-google#13699

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `deletion_policy` to resource `google_compute_shared_vpc_service_project`

modular-magician · 2023-02-14T12:29:11Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-02-14T12:42:16Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

release-note:enhancement

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-02-14T12:42:56Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

release-note:enhancement

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

Signed-off-by: NexusNull <[email protected]>

modular-magician · 2023-02-14T12:46:06Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

release-note:enhancement

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

NexusNull · 2023-02-14T12:51:11Z

Please don't mind the force commits, I had to re-sign the commit with the correct email address.

Signed-off-by: NexusNull <[email protected]>

NexusNull · 2023-02-15T14:33:38Z

I was unable to run the acceptance tests, however I tested it manually without any issues.

melinath

this looks good assuming tests pass, just one nit

mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb

melinath · 2023-02-16T16:52:49Z

/gcbrun

modular-magician · 2023-02-16T17:10:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 117 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 117 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-16T17:11:30Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

melinath

re-marking as changes requested

melinath · 2023-02-16T17:32:51Z

Note: tests are failing due to provider compilation failing:

./google/resource_compute_shared_vpc_test.go:66:5: missing ',' before newline in composite literal

Please generate the provider and run unit tests even if you're not able to run acceptance tests to make sure this is fixed.

…pc_service_project.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

mmv1/third_party/terraform/tests/resource_compute_shared_vpc_test.go

Signed-off-by: NexusNull <[email protected]>

melinath · 2023-02-23T17:29:22Z

/gcbrun

modular-magician · 2023-02-23T17:45:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 115 insertions(+))
Terraform Beta: Diff ( 2 files changed, 115 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-23T18:29:20Z

Tests analytics

Total tests: 2463
Passed tests 2206
Skipped tests: 255
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeSharedVpc_basic|TestAccComputeForwardingRule_update

modular-magician · 2023-02-23T18:34:03Z

Tests passed during RECORDING mode:
TestAccComputeSharedVpc_basic[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

…oogleCloudPlatform#7283) * feat: Add support for deletion_policy on shared vpc service project Signed-off-by: NexusNull <[email protected]> * test: Add tests for deletion_policy on shared vpc service project Signed-off-by: NexusNull <[email protected]> * fix: reorder tests for better coverage Signed-off-by: NexusNull <[email protected]> * Update mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * fix: add comma in test Signed-off-by: NexusNull <[email protected]> * fix formatting Signed-off-by: NexusNull <[email protected]> --------- Signed-off-by: NexusNull <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* main: (41 commits) update the test cases to resolve resourcename not found error Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987) Upgrade DCL to v1.34 (GoogleCloudPlatform#7276) Add max_distance field to group placement policy (GoogleCloudPlatform#7354) Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316) Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310) datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989) Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127) Split resources in "B" products (GoogleCloudPlatform#7350) force recreate on master_config.num_instances (GoogleCloudPlatform#7349) Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343) remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347) Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344) Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345) Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017) Add missing `type` argument to data source docs (GoogleCloudPlatform#7341) Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346) Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339) feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283) fixed virtual field update issues (GoogleCloudPlatform#7318) ...

…oogleCloudPlatform#7283) * feat: Add support for deletion_policy on shared vpc service project Signed-off-by: NexusNull <[email protected]> * test: Add tests for deletion_policy on shared vpc service project Signed-off-by: NexusNull <[email protected]> * fix: reorder tests for better coverage Signed-off-by: NexusNull <[email protected]> * Update mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * fix: add comma in test Signed-off-by: NexusNull <[email protected]> * fix formatting Signed-off-by: NexusNull <[email protected]> --------- Signed-off-by: NexusNull <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

feat: Add support for deletion_policy on shared vpc service project

e9c0b1d

Signed-off-by: NexusNull <[email protected]>

NexusNull added 2 commits February 14, 2023 20:04

test: Add tests for deletion_policy on shared vpc service project

32a7918

Signed-off-by: NexusNull <[email protected]>

fix: reorder tests for better coverage

fae9398

Signed-off-by: NexusNull <[email protected]>

NexusNull marked this pull request as ready for review February 15, 2023 14:32

NexusNull requested a review from a team as a code owner February 15, 2023 14:32

NexusNull requested review from melinath and removed request for a team February 15, 2023 14:32

melinath self-assigned this Feb 15, 2023

melinath requested changes Feb 16, 2023

View reviewed changes

mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb Outdated Show resolved Hide resolved

modular-magician requested a review from melinath February 16, 2023 16:54

melinath requested changes Feb 16, 2023

View reviewed changes

Update mmv1/third_party/terraform/resources/resource_compute_shared_v…

754b834

…pc_service_project.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

melinath requested changes Feb 17, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_shared_vpc_test.go Outdated Show resolved Hide resolved

NexusNull added 2 commits February 19, 2023 19:43

fix: add comma in test

a0ce7e8

Signed-off-by: NexusNull <[email protected]>

fix formatting

8dab2d1

Signed-off-by: NexusNull <[email protected]>

NexusNull requested a review from melinath February 20, 2023 03:52

melinath approved these changes Feb 23, 2023

View reviewed changes

melinath merged commit f9177e1 into GoogleCloudPlatform:main Feb 23, 2023

This was referenced Feb 23, 2023

feat: Add support for deletion_policy on shared vpc service project hashicorp/terraform-provider-google-beta#5243

Merged

feat: Add support for deletion_policy on shared vpc service project hashicorp/terraform-provider-google#13822

Merged

NexusNull mentioned this pull request Jul 7, 2023

add deletion policy documentation #8286

Merged

feat: Add support for deletion_policy on shared vpc service project #7283

feat: Add support for deletion_policy on shared vpc service project #7283

Uh oh!

Conversation

NexusNull commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Feb 14, 2023

Uh oh!

modular-magician commented Feb 14, 2023

Uh oh!

modular-magician commented Feb 14, 2023

Uh oh!

modular-magician commented Feb 14, 2023

Uh oh!

NexusNull commented Feb 14, 2023

Uh oh!

NexusNull commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melinath commented Feb 16, 2023

Uh oh!

modular-magician commented Feb 16, 2023

Diff report

Uh oh!

modular-magician commented Feb 16, 2023

Tests analytics

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

melinath commented Feb 16, 2023

Uh oh!

Uh oh!

melinath commented Feb 23, 2023

Uh oh!

modular-magician commented Feb 23, 2023

Diff report

Uh oh!

modular-magician commented Feb 23, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NexusNull commented Feb 14, 2023 •

edited

Loading

NexusNull commented Feb 15, 2023 •

edited

Loading