Upgrade DCL to v1.34 #7276

c2thorn · 2023-02-10T22:00:14Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

containerazure: added `azure_services_authentication` to `google_container_azure_cluster`

gkehub: deprecated `mesh.control_plane` in `google_gke_hub_feature_membership`. Use `mesh.management` instead (beta-only)

cloudbuild: added `peered_network_ip_range` field to `google_cloudbuild_worker_pool` resource

clouddeploy: added `multi_target` field to `google_clouddeploy_target` resource (beta-only)

modular-magician · 2023-02-10T22:16:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 171 insertions(+), 68 deletions(-))
Terraform Beta: Diff ( 7 files changed, 176 insertions(+), 73 deletions(-))
TF Validator: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

modular-magician · 2023-02-10T22:59:34Z

Tests analytics

Total tests: 2468
Passed tests 2207
Skipped tests: 256
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsRecordSet_basic|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsManagedZone_basic

modular-magician · 2023-02-10T23:11:14Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

LGTM - failing test seems unrelated. It looks like this also adds a couple other fields, which will need release notes:

google_azure_cluster.client
google_cloudbuild_worker_pool.peered_network_ip_range
- This resource has handwritten docs that need to be updated to include the new field.

melinath · 2023-02-13T17:03:11Z

it looks like there should also be a deprecation release note for gke_hub feature membership's control_plane field (beta-only)

c2thorn · 2023-02-13T19:50:09Z

@melinath

google_azure_cluster.client

Client went from required to optional

google_cloudbuild_worker_pool.peered_network_ip_range

This resource has handwritten docs that need to be updated to include the new field.

Good catch, added

it looks like there should also be a deprecation release note for gke_hub feature membership's control_plane field (beta-only)

Added the actual deprecation override, and will add the release note

modular-magician · 2023-02-13T20:03:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 175 insertions(+), 68 deletions(-))
Terraform Beta: Diff ( 8 files changed, 180 insertions(+), 73 deletions(-))
TF Validator: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

modular-magician · 2023-02-13T20:45:48Z

Tests analytics

Total tests: 2470
Passed tests 2208
Skipped tests: 256
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic

modular-magician · 2023-02-13T20:58:18Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeSecurityPolicy_withRateLimitOptions[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-02-13T21:38:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 175 insertions(+), 68 deletions(-))
Terraform Beta: Diff ( 8 files changed, 181 insertions(+), 73 deletions(-))
TF Validator: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

modular-magician · 2023-02-13T22:23:56Z

Tests analytics

Total tests: 2470
Passed tests 2209
Skipped tests: 256
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic

modular-magician · 2023-02-13T22:35:15Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2023-02-23T17:05:12Z

@c2thorn sorry, lost track of this one - it looks like there are a couple of conflicts but otherwise I imagine it's ready? If so could you make sure it's got review requested from me after the change?

melinath · 2023-02-23T17:06:39Z

#7335 had also added the peered network ip range field to a few tests, not sure if you might want to do that here.

modular-magician · 2023-02-24T18:17:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 168 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 10 files changed, 232 insertions(+), 74 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2023-02-24T18:33:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 170 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 11 files changed, 234 insertions(+), 74 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2023-02-24T19:18:38Z

Tests analytics

Total tests: 2473
Passed tests 2214
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccCloudbuildWorkerPool_withNetwork|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-24T20:10:10Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2023-02-24T20:46:40Z

@melinath there are no cloud workstation changes here, so the test seems unrelated

melinath

LGTM - one small thing: google_gke_hub_feature_membership docs seem to be handwritten, so the deprecation notice will need to be moved over manually.

c2thorn · 2023-02-27T21:06:58Z

LGTM - one small thing: google_gke_hub_feature_membership docs seem to be handwritten, so the deprecation notice will need to be moved over manually.

Looks like it was never in the docs to begin with. I believe the field was added as a workaround for a specific case and not really meant for much widespread use. I'm opting to not add it to the docs just for it to be deprecated in favor of a field that's already included. Let me know if you think otherwise.

melinath · 2023-02-27T21:07:40Z

I'm opting to not add it to the docs just for it to be deprecated in favor of a field that's already included.

Sounds like the right call - thanks!

modular-magician · 2023-02-27T21:16:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 206 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 12 files changed, 373 insertions(+), 74 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2023-02-27T21:59:04Z

Tests analytics

Total tests: 2477
Passed tests 2219
Skipped tests: 255
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccClouddeployTarget_MultiTarget|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-27T23:06:03Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccClouddeployTarget_MultiTarget[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Co-authored-by: Louis Jimenez <[email protected]>

* main: (41 commits) update the test cases to resolve resourcename not found error Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987) Upgrade DCL to v1.34 (GoogleCloudPlatform#7276) Add max_distance field to group placement policy (GoogleCloudPlatform#7354) Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316) Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310) datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989) Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127) Split resources in "B" products (GoogleCloudPlatform#7350) force recreate on master_config.num_instances (GoogleCloudPlatform#7349) Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343) remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347) Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344) Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345) Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017) Add missing `type` argument to data source docs (GoogleCloudPlatform#7341) Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346) Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339) feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283) fixed virtual field update issues (GoogleCloudPlatform#7318) ...

Co-authored-by: Louis Jimenez <[email protected]>

c2thorn requested a review from a team as a code owner February 10, 2023 22:00

c2thorn requested review from melinath and removed request for a team February 10, 2023 22:00

melinath requested changes Feb 13, 2023

View reviewed changes

rileykarson mentioned this pull request Feb 15, 2023

Update non-DCL dependencies to latest patch versions #7304

Closed

5 tasks

melinath mentioned this pull request Feb 23, 2023

Adding peered_network_ip_range field to google_cloudbuild_worker_pool #7335

Closed

5 tasks

c2thorn added 5 commits February 24, 2023 11:59

Upgrade DCL to v1.33

7c95ad4

update documentation

922c40f

deprecate control_plane

2e7abac

control_plane pathing

32fc7ec

dcl 1.34

a08e2aa

c2thorn force-pushed the dcl-upgrade branch from c9443da to a08e2aa Compare February 24, 2023 18:00

use peered_network_ip_range in test

e811c51

c2thorn changed the title ~~Upgrade DCL to v1.33~~ Upgrade DCL to v1.34 Feb 24, 2023

rileykarson mentioned this pull request Feb 27, 2023

Upgrade DCL to 1.34.0 #7352

Closed

melinath approved these changes Feb 27, 2023

View reviewed changes

Add sample tests for Cloud Deploy multi_target

a8ba7ba

c2thorn merged commit 1a2253a into GoogleCloudPlatform:main Feb 27, 2023

This was referenced Feb 27, 2023

Upgrade DCL to v1.34 hashicorp/terraform-provider-google-beta#5258

Merged

Upgrade DCL to v1.34 hashicorp/terraform-provider-google#13854

Merged

mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023

Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)

ab05eac

Co-authored-by: Louis Jimenez <[email protected]>

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)

e647a03

Co-authored-by: Louis Jimenez <[email protected]>

c2thorn mentioned this pull request Aug 9, 2023

Move sign_in from google_identity_platform_project_default_config to google_identity_platform_config. #8559

Merged

5 tasks

Upgrade DCL to v1.34 #7276

Upgrade DCL to v1.34 #7276

Uh oh!

Conversation

c2thorn commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Feb 10, 2023

Diff report

Uh oh!

modular-magician commented Feb 10, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 10, 2023

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

melinath commented Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c2thorn commented Feb 13, 2023

Uh oh!

modular-magician commented Feb 13, 2023

Diff report

Uh oh!

modular-magician commented Feb 13, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 13, 2023

Uh oh!

modular-magician commented Feb 13, 2023

Diff report

Uh oh!

modular-magician commented Feb 13, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 13, 2023

Uh oh!

melinath commented Feb 23, 2023

Uh oh!

melinath commented Feb 23, 2023

Uh oh!

modular-magician commented Feb 24, 2023

Diff report

Uh oh!

modular-magician commented Feb 24, 2023

Diff report

Uh oh!

modular-magician commented Feb 24, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 24, 2023

Uh oh!

c2thorn commented Feb 24, 2023

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

c2thorn commented Feb 27, 2023

Uh oh!

melinath commented Feb 27, 2023

Uh oh!

modular-magician commented Feb 27, 2023

Diff report

Uh oh!

modular-magician commented Feb 27, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

c2thorn commented Feb 10, 2023 •

edited

Loading

melinath commented Feb 13, 2023 •

edited

Loading