Fix buggy IAM import tests previously excluded using `skip_import_test` #7240

SarahFrench · 2023-02-07T15:03:30Z

Relates to hashicorp/terraform-provider-google#12610

This PR:

is linked to this previous PR, which introduced ignoring of import steps in acc tests for IAM resources : Allow import steps in beta IAM resource tests #7185
removes skip_import_test from some resources so that the IAM acceptance tests include import steps
fixes the yaml to allow those import steps to pass
leaves some tests with skipped import steps, due to the import identifier needing to include an id that's made by the API at create time (we don't have sufficient prior knowledge when configuring the test)

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-02-07T15:19:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 8 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 13 files changed, 209 insertions(+), 54 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 16 insertions(+), 16 deletions(-))

modular-magician · 2023-02-07T15:34:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 17 files changed, 309 insertions(+), 100 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 24 insertions(+), 24 deletions(-))

modular-magician · 2023-02-07T16:14:33Z

Tests analytics

Total tests: 2454
Passed tests 2157
Skipped tests: 255
Failed tests: 42

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataprocMetastoreFederationIamMemberGenerated|TestAccDataprocMetastoreFederationIamBindingGenerated|TestAccRegionInstanceGroupManager_stateful|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayGateway_apigatewayGatewayFullExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated|TestAccApiGatewayApi_apigatewayApiFullExample|TestAccApiGatewayApi_apigatewayApiBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample|TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccFrameworkProviderMeta_setModuleName|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayApiIamPolicyGenerated|TestAccApiGatewayApiIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccApiGatewayApiIamBindingGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeMachineImageIamBindingGenerated|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample

modular-magician · 2023-02-07T16:32:27Z

Tests passed during RECORDING mode:
TestAccComputeMachineImage_machineImageBasicExample[Debug log]
TestAccComputeMachineImage_computeMachineImageKmsExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample[Debug log]
TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApiGatewayGateway_apigatewayGatewayFullExample[Debug log]
TestAccApiGatewayGateway_apigatewayGatewayBasicExample[Debug log]
TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated[Debug log]
TestAccApiGatewayApi_apigatewayApiFullExample[Debug log]
TestAccApiGatewayApi_apigatewayApiBasicExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample[Debug log]
TestAccRuntimeConfigConfigIamPolicyGenerated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeMachineImageIamPolicyGenerated_withCondition[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccComputeMachineImageIamMemberGenerated_withCondition[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]
TestAccApiGatewayGatewayIamBindingGenerated[Debug log]
TestAccApiGatewayApiIamPolicyGenerated[Debug log]
TestAccApiGatewayApiIamMemberGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccApiGatewayApiIamBindingGenerated[Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Debug log]
TestAccComputeMachineImageIamBindingGenerated_withCondition[Debug log]
TestAccApiGatewayGatewayIamPolicyGenerated[Debug log]
TestAccApiGatewayGatewayIamMemberGenerated[Debug log]
TestAccComputeMachineImageIamPolicyGenerated[Debug log]
TestAccComputeMachineImageIamMemberGenerated[Debug log]
TestAccComputeMachineImageIamBindingGenerated[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccDataprocMetastoreFederationIamMemberGenerated[Error message] [Debug log]
TestAccDataprocMetastoreFederationIamBindingGenerated[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample[Error message] [Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-02-08T14:59:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 17 files changed, 309 insertions(+), 100 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 24 insertions(+), 24 deletions(-))

modular-magician · 2023-02-08T15:39:11Z

Tests analytics

Total tests: 2458
Passed tests 2187
Skipped tests: 256
Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataprocMetastoreFederationIamBindingGenerated|TestAccDataprocMetastoreFederationIamMemberGenerated|TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccFrameworkProviderMeta_setModuleName|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic

modular-magician · 2023-02-08T15:51:42Z

Tests passed during RECORDING mode:
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataprocMetastoreFederationIamBindingGenerated[Error message] [Debug log]
TestAccDataprocMetastoreFederationIamMemberGenerated[Error message] [Debug log]
TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample[Error message] [Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-02-20T15:33:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 13 files changed, 202 insertions(+), 86 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 10 files changed, 20 insertions(+), 20 deletions(-))

modular-magician · 2023-02-20T16:20:00Z

Tests analytics

Total tests: 2467
Passed tests 2203
Skipped tests: 256
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccComputeForwardingRule_update|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample

modular-magician · 2023-02-20T16:33:03Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2023-02-20T17:03:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 13 files changed, 264 insertions(+), 86 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 10 files changed, 20 insertions(+), 20 deletions(-))

modular-magician · 2023-02-20T17:45:13Z

Tests analytics

Total tests: 2467
Passed tests 2204
Skipped tests: 256
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayGatewayIamPolicyGenerated

modular-magician · 2023-02-20T17:57:30Z

Tests passed during RECORDING mode:
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApiGatewayGatewayIamMemberGenerated[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApiGatewayGatewayIamPolicyGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccApiGatewayApiConfigIamPolicyGenerated[Error message] [Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Error message] [Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench · 2023-02-20T18:03:19Z

For the last tests, this is the error showing the expected ID for the resource:

provider_test.go:315: Failed state verification, resource with ID projects/[PROJECT_ID]/locations/global/apis/tf-test-my-api7fa67niliq/configs/tf-test-my-config7fa67niliq not found

Here's the actual name from the debug logs:

"name": "projects/[PROJECT_NUMBER]/locations/global/apis/tf-test-my-api7fa67niliq/configs/terraform-20230220174708497600000001",

I'll re-ignore those tests and leave it at that 😆

modular-magician · 2023-02-20T18:22:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 13 files changed, 202 insertions(+), 86 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 10 files changed, 20 insertions(+), 20 deletions(-))

modular-magician · 2023-02-20T19:04:56Z

Tests analytics

Total tests: 2467
Passed tests 2205
Skipped tests: 256
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated

modular-magician · 2023-02-20T19:17:23Z

Tests passed during RECORDING mode:
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApiGatewayGatewayIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Debug log]

All tests passed
View the build log or the debug log for each test

SarahFrench · 2023-02-27T12:29:50Z

mmv1/products/apigateway/terraform.yaml

+        primary_resource_name: "fmt.Sprintf(\"tf-test-my-api%s\", context[\"random_suffix\"])"
        vars:
-          name: "api"
+          api_id: "my-api"


Explanation: I updated the name of the vars because in tests where 3 names were being passed in it was easier to understand if they all had consistent names that matched the argument they were used for. For consistency I did this across all tests.

I updated the value to include a hyphen, as presence of the hyphen is needed to cause the generated test code to include tf-test- at the start of the value and the random suffix (from context) at the end.

SarahFrench · 2023-03-15T16:18:43Z

Just rebased the branch and fixed a merge conflict due to the mmv1/products/metastore/api.yaml being removed from the repo

mmv1/products/apigateway/terraform.yaml

Co-authored-by: Riley Karson <[email protected]>

modular-magician · 2023-03-15T16:39:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 13 files changed, 202 insertions(+), 86 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 10 files changed, 20 insertions(+), 20 deletions(-))

modular-magician · 2023-03-15T17:25:36Z

Tests analytics

Total tests: 2500
Passed tests 2225
Skipped tests: 263
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated

Get to know how VCR tests work

modular-magician · 2023-03-15T18:18:23Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamBindingGenerated[Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench · 2023-03-15T20:14:09Z

Failing VCR test isn't related to this PR; merging!

…t` (GoogleCloudPlatform#7240) * Add ability to skip import steps in IAM resource tests * Fix ApiGateway IAM import tests * Fix Compute MachineImage IAM import tests * Fix DataprocMetastore Federation IAM import tests * Remove `skip_import_test` from ApiConfig and Gateway resources * Re-add import step skipping in IAM acc tests * Update mmv1/products/apigateway/terraform.yaml Co-authored-by: Riley Karson <[email protected]> --------- Co-authored-by: Riley Karson <[email protected]>

GoogleCloudPlatform deleted a comment from modular-magician Feb 7, 2023

SarahFrench force-pushed the fix-ignored-iam-import-tests branch from 8da4973 to 3cc0a5b Compare February 7, 2023 15:21

SarahFrench mentioned this pull request Feb 7, 2023

Allow import steps in beta IAM resource tests - failing tests #6580

Closed

5 tasks

SarahFrench force-pushed the fix-ignored-iam-import-tests branch from 3cc0a5b to 02c4fe4 Compare February 8, 2023 14:43

SarahFrench force-pushed the fix-ignored-iam-import-tests branch from ffc6386 to bc3493b Compare February 20, 2023 15:18

SarahFrench marked this pull request as ready for review February 20, 2023 19:52

SarahFrench requested a review from a team as a code owner February 20, 2023 19:52

SarahFrench requested review from rileykarson and removed request for a team February 20, 2023 19:52

SarahFrench commented Feb 27, 2023

View reviewed changes

SarahFrench added 3 commits March 15, 2023 16:13

Add ability to skip import steps in IAM resource tests

513c40b

Fix ApiGateway IAM import tests

72ea0db

Fix Compute MachineImage IAM import tests

f820396

SarahFrench added 3 commits March 15, 2023 16:17

Fix DataprocMetastore Federation IAM import tests

9690f95

Remove skip_import_test from ApiConfig and Gateway resources

d12dc09

Re-add import step skipping in IAM acc tests

a1240be

SarahFrench force-pushed the fix-ignored-iam-import-tests branch from a439152 to a1240be Compare March 15, 2023 16:17

rileykarson approved these changes Mar 15, 2023

View reviewed changes

mmv1/products/apigateway/terraform.yaml Outdated Show resolved Hide resolved

Update mmv1/products/apigateway/terraform.yaml

ff81dc2

Co-authored-by: Riley Karson <[email protected]>

SarahFrench merged commit 1d56265 into GoogleCloudPlatform:main Mar 15, 2023

SarahFrench deleted the fix-ignored-iam-import-tests branch March 26, 2024 11:15

Fix buggy IAM import tests previously excluded using skip_import_test #7240

Fix buggy IAM import tests previously excluded using skip_import_test #7240

Uh oh!

Conversation

SarahFrench commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Feb 7, 2023

Diff report

Uh oh!

modular-magician commented Feb 7, 2023

Diff report

Uh oh!

modular-magician commented Feb 7, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 7, 2023

Uh oh!

modular-magician commented Feb 8, 2023

Diff report

Uh oh!

modular-magician commented Feb 8, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 8, 2023

Uh oh!

modular-magician commented Feb 20, 2023

Diff report

Uh oh!

modular-magician commented Feb 20, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 20, 2023

Uh oh!

modular-magician commented Feb 20, 2023

Diff report

Uh oh!

modular-magician commented Feb 20, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 20, 2023

Uh oh!

SarahFrench commented Feb 20, 2023

Uh oh!

modular-magician commented Feb 20, 2023

Diff report

Uh oh!

modular-magician commented Feb 20, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 20, 2023

Uh oh!

SarahFrench Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

SarahFrench commented Mar 15, 2023

Uh oh!

Uh oh!

modular-magician commented Mar 15, 2023

Diff report

Uh oh!

modular-magician commented Mar 15, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 15, 2023

Uh oh!

SarahFrench commented Mar 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Fix buggy IAM import tests previously excluded using `skip_import_test` #7240

Fix buggy IAM import tests previously excluded using `skip_import_test` #7240

SarahFrench commented Feb 7, 2023 •

edited

Loading