Adding Cloud Build Connection and Repository resources to beta provider. #7157

vicpadilla · 2023-01-23T16:56:14Z

Adding Cloud Build Connection and Repository resources to beta provider.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloudbuildv2_connection` (beta)

`google_cloudbuildv2_repository` (beta)

modular-magician · 2023-01-23T17:11:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 369 insertions(+))
Terraform Beta: Diff ( 10 files changed, 1778 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-23T17:56:44Z

Tests analytics

Total tests: 2428
Passed tests 2168
Skipped tests: 254
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudbuildv2Repository_GithubRepository|TestAccCloudbuildv2Repository_GheRepository

modular-magician · 2023-01-23T18:00:27Z

Tests passed during RECORDING mode:
TestAccCloudbuildv2Connection_GithubConnection[Debug log]
TestAccCloudbuildv2Connection_GheConnection[Debug log]
TestAccCloudbuildv2Repository_GithubRepository[Debug log]
TestAccCloudbuildv2Repository_GheRepository[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-23T19:01:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 362 insertions(+))
Terraform Beta: Diff ( 10 files changed, 1762 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-23T19:48:29Z

Tests analytics

Total tests: 2429
Passed tests 2174
Skipped tests: 254
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-23T19:51:10Z

Tests failed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

Here's my questions after a first pass through! Ideally the api/service/samples directory here would be a 1:1 copy of what's in the DCL folder at https://github.com/GoogleCloudPlatform/declarative-resource-client-library/tree/main/services/google/cloudbuildv2/samples, so I'm curious if we'd be able to correct the differences between the two.

If that's not possible, I'd like to cover update in the Terraform tests as well. In addition to make sure we didn't introduce an issue between here and the DCL (where it's already tested!), we collect HTTP logs from our CI and reference those when debugging customer bugs.

tpgtools/overrides/cloudbuildv2/samples/repository/meta.yaml

tpgtools/api/cloudbuildv2/samples/ghe_connection.yaml

tpgtools/api/cloudbuildv2/samples/ghe.connection.json

tpgtools/api/cloudbuildv2/samples/ghe_connection.yaml

modular-magician · 2023-01-27T15:31:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 360 insertions(+))
Terraform Beta: Diff ( 10 files changed, 2010 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T16:05:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 360 insertions(+))
Terraform Beta: Diff ( 10 files changed, 2010 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T16:54:06Z

Tests analytics

Total tests: 2442
Passed tests 2180
Skipped tests: 254
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation|TestAccCloudbuildv2Connection_GhePrivConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GheCompleteConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Repository_GithubRepository|TestAccCloudbuildv2Connection_GithubConnection

modular-magician · 2023-01-27T17:09:03Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]
TestAccCloudbuildv2Connection_GheCompleteConnection[Debug log]
TestAccCloudbuildv2Repository_GithubRepository[Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

vicpadilla · 2023-01-27T17:55:29Z

/gcbrun

rileykarson · 2023-01-27T18:00:50Z

/gcbrun

modular-magician · 2023-01-27T18:16:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 360 insertions(+))
Terraform Beta: Diff ( 10 files changed, 2010 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T19:00:32Z

Tests analytics

Total tests: 2442
Passed tests 2184
Skipped tests: 254
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudbuildv2Connection_GhePrivConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-27T19:16:59Z

Tests passed during RECORDING mode:
TestAccCloudbuildv2Connection_GhePrivConnection[Debug log]
TestAccCloudbuildv2Connection_GheConnection[Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Debug log]
TestAccContainerCluster_failedCreation[Debug log]

All tests passed
View the build log or the debug log for each test

…er. (GoogleCloudPlatform#7157)

Adding Cloud Build Connection and Repository resources to beta provider.

64a1b25

vicpadilla requested a review from rileykarson as a code owner January 23, 2023 16:56

vicpadilla mentioned this pull request Jan 23, 2023

Add support for google_cloudbuildv2_connection and google_cloudbuildv2_repository #6756

Closed

5 tasks

Remove unnecessary project values from examples.

aeafa4b

rileykarson reviewed Jan 27, 2023

View reviewed changes

Sync tests to DCL samples

3d3769b

modular-magician requested a review from rileykarson January 27, 2023 15:17

Adjusting indentation in example.

8c9c9dc

rileykarson approved these changes Jan 27, 2023

View reviewed changes

rileykarson merged commit 70985d1 into GoogleCloudPlatform:main Jan 27, 2023

rileykarson mentioned this pull request Jan 27, 2023

CloudBuild V2 Connection IAM resources #6778

Merged

5 tasks

This was referenced Jan 27, 2023

Adding Cloud Build Connection and Repository resources to beta provider. hashicorp/terraform-provider-google-beta#5140

Merged

Adding Cloud Build Connection and Repository resources to beta provider. hashicorp/terraform-provider-google#13589

Merged

melinath added the service/cloudbuild label Feb 7, 2023

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Adding Cloud Build Connection and Repository resources to beta provid…

9dcc909

…er. (GoogleCloudPlatform#7157)

Adding Cloud Build Connection and Repository resources to beta provider. #7157

Adding Cloud Build Connection and Repository resources to beta provider. #7157

Uh oh!

Conversation

vicpadilla commented Jan 23, 2023 • edited by rileykarson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jan 23, 2023

Diff report

Uh oh!

modular-magician commented Jan 23, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 23, 2023

Uh oh!

modular-magician commented Jan 23, 2023

Diff report

Uh oh!

modular-magician commented Jan 23, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 23, 2023

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Jan 27, 2023

Diff report

Uh oh!

modular-magician commented Jan 27, 2023

Diff report

Uh oh!

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 27, 2023

Uh oh!

vicpadilla commented Jan 27, 2023

Uh oh!

rileykarson commented Jan 27, 2023

Uh oh!

modular-magician commented Jan 27, 2023

Diff report

Uh oh!

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vicpadilla commented Jan 23, 2023 •

edited by rileykarson

Loading