Skip to content

Revert "retrieve project from the name" #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melinath merged 1 commit into from
Jan 3, 2023
Merged

Revert "retrieve project from the name" #7072

melinath merged 1 commit into from
Jan 3, 2023

Conversation

@melinath
Copy link
Member

@melinath melinath commented Jan 3, 2023 •
edited
Loading

Reverts #7063

REVERT: datacatalog: fixed the import failure when the `project` is different from the default on `google_data_catalog_taxonomy`

@modular-magician

This comment was marked as resolved.

Sign in to view
@melinath melinath requested review from a team and shuyama1 and removed request for a team January 3, 2023 22:53
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2023

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 1 file changed, 7 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2023

Tests analytics

Total tests: 2386
Passed tests 2135
Skipped tests: 248
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2023

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

@melinath melinath merged commit 7cfe5b3 into main Jan 3, 2023
@melinath melinath deleted the revert-7063-issue13307 branch January 3, 2023 23:49
This was referenced Jan 3, 2023
Merged
Merged
i-laird pushed a commit to i-laird/magic-modules that referenced this pull request Jan 10, 2023
@melinath @i-laird
Revert "retrieve project from the name (GoogleCloudPlatform#7063)" (G…
dfdeb77 
…oogleCloudPlatform#7072)

This reverts commit 5b9e699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melinath @modular-magician @shuyama1