retrieve project from the name #7063
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform Beta: Diff ( 1 file changed, 7 insertions(+)) |
|
The provider crashed while running the VCR tests in REPLAYING mode |
mmv1/templates/terraform/custom_import/data_catalog_taxonomy.go.erb
Outdated
Show resolved
Hide resolved
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
Happy new year! This PR looks good to me, and I like how you've used FindStringSubmatch to get values instead of just splitting the name string by /.
I've included a suggested change for a nit about indentation, but I'll approve as it's not blocking
SarahFrench
dismissed
their stale review
Want to check if there's a better approach to do this for generated resources
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
I re-requested myself for review because I learned some more about the parseImportId function from Riley and I wanted to make sure I understood this problem fully.
From my understanding, the import code usually made for generated resources would pull in project names ok, but this resource's names can include slashes so we need to use custom import code, right?
In that case, re-approved!
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform Beta: Diff ( 1 file changed, 7 insertions(+)) |
|
The provider crashed while running the VCR tests in REPLAYING mode |
|
@SarahFrench usually name is short while id is long. In this case, the name is long and no other fields (like project and locations) are available which are needed for building the url for read call. I looked up the attributes and it appears we have to parse the name to obtain the project and the location. Fortunately there is already the import custom code which makes the fix a little easier. |
|
This appears to be causing a crash in VCR runs @edwardmedia |
* retrieve project from the name * reformat for indentation Co-authored-by: Edward Sun <[email protected]>
4 participants
Fixes hashicorp/terraform-provider-google#13307
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)