Skip to content

Remove rotation_period config from TestAccLoggingBucketConfigProject_cmekSettings #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zli82016 merged 1 commit into from
Dec 21, 2022
Merged

Remove rotation_period config from TestAccLoggingBucketConfigProject_cmekSettings #7020

zli82016 merged 1 commit into from
Dec 21, 2022

Conversation

@roaks3
Copy link
Contributor

@roaks3 roaks3 commented Dec 21, 2022

fixes hashicorp/terraform-provider-google#13259

A large number of our PRs are running the TestAccLoggingBucketConfigProject_cmekSettings in RECORDING mode, even if they have not modified any related code. This is happening because the rotation_period for the crypto_keys introduces a time element that changes on subsequent runs, and the API requests cannot match against previous calls.

This PR removes the rotation_period config to hopefully make the API calls matchable again.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@roaks3
Remove rotation_period config from TestAccLoggingBucketConfigProject_…
aac755b 
…cmekSettings so VCR tests can match to prior runs
@modular-magician
Copy link
Collaborator

modular-magician commented Dec 21, 2022

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Dec 21, 2022

Tests analytics

Total tests: 2370
Passed tests 2119
Skipped tests: 247
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComputeForwardingRule_update|TestAccDataSourceGoogleServiceAccountJwt|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

modular-magician commented Dec 21, 2022

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

@roaks3 roaks3 requested a review from zli82016 December 21, 2022 21:11
@roaks3
Copy link
Contributor Author

roaks3 commented Dec 21, 2022

@zli82016 I think I have the right solution here, but wanted to confirm with you that it makes sense and that the rotation_period can be safely removed.

@zli82016 zli82016 requested review from a team and c2thorn and removed request for a team December 21, 2022 21:28
@zli82016
Copy link
Member

zli82016 commented Dec 21, 2022 •
edited
Loading

Added @c2thorn as the secondary reviewer. Please wait for @c2thorn review.

zli82016
zli82016 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. rotation_period is optional and can be removed.

c2thorn
c2thorn approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find.

@zli82016 zli82016 merged commit 5cd80bb into main Dec 21, 2022
This was referenced Dec 21, 2022
Merged
Merged
@zli82016 zli82016 deleted the fix-persistent-logging-bucket-vcr-test branch December 21, 2022 22:47
rlapin-pl pushed a commit to rlapin-pl/magic-modules that referenced this pull request Jan 1, 2023
@roaks3
Remove rotation_period config from TestAccLoggingBucketConfigProject_…
1a5da2b 
…cmekSettings so VCR tests can match to prior runs (GoogleCloudPlatform#7020)
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Jan 3, 2023
@roaks3 @kimihrr
Remove rotation_period config from TestAccLoggingBucketConfigProject_…
aaca635 
…cmekSettings so VCR tests can match to prior runs (GoogleCloudPlatform#7020)
This was referenced Mar 7, 2023
Closed
Closed
@roaks3 roaks3 mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c2thorn c2thorn c2thorn approved these changes

@zli82016 zli82016 zli82016 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccLoggingBucketConfigProject_cmekSettings

4 participants

@roaks3 @modular-magician @zli82016 @c2thorn