Skip to content

Disabled TFV compute_security_policy tests due to inconsistent handling of rule field #6904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melinath merged 1 commit into from
Dec 2, 2022
Merged

Disabled TFV compute_security_policy tests due to inconsistent handling of rule field #6904

melinath merged 1 commit into from
Dec 2, 2022

Conversation

@melinath
Copy link
Member

@melinath melinath commented Dec 2, 2022 •
edited
Loading

Rule field is a set field, so the ordering is arbitrary. Disabling for now & will open a ticket to improve the tests for this case.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@melinath melinath requested a review from shuyama1 December 2, 2022 17:05
shuyama1
shuyama1 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume tests pass

@modular-magician
Copy link
Collaborator

modular-magician commented Dec 2, 2022

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 5 files changed, 399 deletions(-))

@melinath
Copy link
Member Author

melinath commented Dec 2, 2022

No changes to the providers, so I'm merging this even though VCR is still running.

@melinath melinath merged commit 5d8c5a3 into main Dec 2, 2022
@melinath melinath deleted the tfv-test-failures branch December 2, 2022 17:38
@modular-magician modular-magician mentioned this pull request Dec 2, 2022
Merged
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Dec 2, 2022

Tests analytics

Total tests: 2311
Passed tests 2065
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

modular-magician commented Dec 2, 2022

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022
@melinath @kimihrr
Disabled TFV compute_security_policy tests due to inconsistent handli…
e2785ac 
…ng of rule field (GoogleCloudPlatform#6904)
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
@melinath @hao-nan-li
Disabled TFV compute_security_policy tests due to inconsistent handli…
4814af6 
…ng of rule field (GoogleCloudPlatform#6904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melinath @modular-magician @shuyama1