Skip to content

Add a test for GKEHub servicemesh and exclude Eventarc trigger channel #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SirGitsalot wants to merge 1 commit into from
Closed

Add a test for GKEHub servicemesh and exclude Eventarc trigger channel #6731

SirGitsalot wants to merge 1 commit into from

Conversation

@SirGitsalot
Copy link
Member

@SirGitsalot SirGitsalot commented Oct 22, 2022

Add a test for GKEHub servicemesh and exclude Eventarc trigger channel

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 22, 2022

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@SirGitsalot
Copy link
Member Author

SirGitsalot commented Oct 22, 2022

Not for actual merging - this contains some examples for inclusion into #6639

@SirGitsalot SirGitsalot mentioned this pull request Oct 22, 2022
Merged
4 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Oct 22, 2022

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 96 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 15 files changed, 758 insertions(+), 126 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 22, 2022

Tests analytics

Total tests: 2204
Passed tests 1916
Skipped tests: 240
Failed tests: 48

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRouterInterface_basic|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeRoute_routeIlbExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeForwardingRule_update|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_ip|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyRule_multipleRules

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 22, 2022

Tests passed during RECORDING mode:
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]

Errors occurred during RECORDING mode. Please fix them to complete your PR
View the build log or the debug log for each test

@rileykarson rileykarson closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rileykarson rileykarson Awaiting requested review from rileykarson

Assignees

No one assigned

Labels

stale-pr-closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SirGitsalot @modular-magician @rileykarson