Skip to content

Adds liveness_probe field to google_cloud_run_service resource for beta #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melinath merged 5 commits into from
Oct 14, 2022
Merged

Adds liveness_probe field to google_cloud_run_service resource for beta #6677

melinath merged 5 commits into from
Oct 14, 2022

Conversation

@yanweiguo
Copy link
Member

@yanweiguo yanweiguo commented Oct 11, 2022 •
edited
Loading

Part of hashicorp/terraform-provider-google#12532.

Adds liveness_probe field to google_cloud_run_service resource for google beta provider.

This one is similar to #6532.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: added field `liveness_probe` to resource `google_cloud_run_service` (beta)

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 4 files changed, 450 insertions(+), 15 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Tests analytics

Total tests: 2215
Passed tests 1971
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceProbesExample|TestAccCloudRunService_probes|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Tests passed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceProbesExample[Debug log]
TestAccCloudRunService_probes[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath
melinath requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; a few questions.

It looks like successThreshold is currently omitted - I'm guessing because it's not meaningful at the moment?

tcpSocket and grpc are currently omitted - are they supported by Cloud Run?

@yanweiguo @melinath
Update mmv1/products/cloudrun/api.yaml
07926ab 
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@yanweiguo
Copy link
Member Author

yanweiguo commented Oct 13, 2022

Looking good; a few questions.

It looks like successThreshold is currently omitted - I'm guessing because it's not meaningful at the moment?

tcpSocket and grpc are currently omitted - are they supported by Cloud Run?

Cloud Run shares the same API with knative based on k8s. Some fields are defined by knative/k8s but not supported by Cloud Run. successThreshold, tcpSocket and grpc are such fields currently. It might change in the future. (grpc support is coming soon)

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 13, 2022

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 65 insertions(+))
Terraform Beta: Diff ( 4 files changed, 471 insertions(+), 24 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 13, 2022

Tests analytics

Total tests: 2186
Passed tests 1946
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 13, 2022

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@melinath
Copy link
Member

melinath commented Oct 13, 2022

I'm running a manual set of tests out of an abundance of caution, but it's probably fine. https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/345139

@melinath melinath merged commit e2da1b7 into GoogleCloudPlatform:main Oct 14, 2022
This was referenced Oct 14, 2022
Merged
Merged
Merged
@yanweiguo yanweiguo mentioned this pull request Nov 3, 2022
Merged
5 tasks
This was referenced Nov 9, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath melinath approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanweiguo @modular-magician @melinath