Skip to content

Upgrade the dcl version to v1.26.0 #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melinath merged 22 commits into from
Nov 7, 2022
Merged

Upgrade the dcl version to v1.26.0 #6639

melinath merged 22 commits into from
Nov 7, 2022

Conversation

@alphanota
Copy link
Contributor

@alphanota alphanota commented Oct 4, 2022 •
edited
Loading

Upgrade the dcl version to v1.26.0
The reason for this upgrade is to add new fields to the DeliveryPipeline and Target resources.
A fix for #12714 is also included.

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

clouddeploy: Added support for Cloud Run Targets (beta)

clouddeploy: Added support for Deployment Verification standard strategy (beta)

clouddeploy: Added execution_configs.execution_timeout in target resource. (beta)

compute: machine_type field in compute instance resource now accepts short name.

orgpolicy: Changed spec.rules type from Array to Set in policy resource.
https://github.com/hashicorp/terraform-provider-google/issues/12363

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 4, 2022

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 4, 2022

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 12 files changed, 191 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 16 files changed, 848 insertions(+), 109 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 4, 2022

Tests analytics

Total tests: 2200
Passed tests 1899
Skipped tests: 240
Failed tests: 61

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccClouddeployTarget_Target|TestAccClouddeployTarget_RunTarget|TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_update

@alphanota alphanota mentioned this pull request Oct 4, 2022
Closed
@modular-magician
Copy link
Collaborator

modular-magician commented Oct 4, 2022

Tests passed during RECORDING mode:
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccClouddeployTarget_Target[Debug log]
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccOrgPolicyPolicy_FolderPolicy[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath
melinath requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the failure of TestAccOrgPolicyPolicy_FolderPolicy is likely related to this change, since it's a DCL-based resource. Please look into that & resolve.

Also, please update the release notes according to the guide.

@rileykarson
Copy link
Member

rileykarson commented Oct 5, 2022

Note that #6614 is ongoing to reach 1.22.0

@rileykarson rileykarson mentioned this pull request Oct 5, 2022
Merged
5 tasks
@rileykarson
Copy link
Member

rileykarson commented Oct 5, 2022

@avinash84 fyi

@alphanota
Copy link
Contributor Author

alphanota commented Oct 5, 2022

@rileykarson Hi yes, we would like to push v.1.23 instead of v.1.22 since we want to release these new features in the beta version.

@alphanota alphanota mentioned this pull request Oct 5, 2022
Closed
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Oct 6, 2022

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 191 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 16 files changed, 848 insertions(+), 109 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 6, 2022

Tests analytics

Total tests: 2208
Passed tests 1925
Skipped tests: 240
Failed tests: 43

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccClouddeployTarget_RunTarget|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeFirewallPolicy_update

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 6, 2022

Tests passed during RECORDING mode:
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccClouddeployTarget_RunTarget[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccOrgPolicyPolicy_FolderPolicy[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath
melinath requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests related to this PR. Also, if this replaces the other DCL PR, please be sure to include the changes from it.

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 185 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 16 files changed, 911 insertions(+), 124 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Tests analytics

Total tests: 2218
Passed tests 1952
Skipped tests: 240
Failed tests: 26

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccDataSourceGoogleGlobalForwardingRule

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 11, 2022

Tests passed during RECORDING mode:
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@avinash84
Copy link
Contributor

avinash84 commented Oct 13, 2022

/gcbrun

@alphanota
Copy link
Contributor Author

alphanota commented Oct 13, 2022

Hi @melinath we made the requested fixes. Would you be able to review again and verify if the new VCR failures are of concern? Thank you!

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 24, 2022

Tests passed during RECORDING mode:
TestAccDNSRecordSet_routingPolicy[Debug log]
TestAccDNSRecordSet_changeRouting[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccContainerAzureCluster_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAwsCluster_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath
melinath requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are two permadiffs causing the following tests to fail:

  • TestAccContainerAzureCluster_BetaBasicHandWritten
  • TestAccContainerAwsCluster_BetaBasicHandWritten

Since the monitoring_config fields are new in this PR, you could either fix the tests or exclude the field additions for now & fix them later.

TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample seems unrelated.

@ghabian
Copy link
Contributor

ghabian commented Oct 25, 2022

TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample seems unrelated.

merged PR #6726 should fix this test going forward

@daveavi
Copy link
Contributor

daveavi commented Oct 25, 2022

@alphanota See #6731 to copy over a test for gkehub_feature_membership mesh and exclusions for the channel field for eventarc trigger

@daveavi for vis since you'll need to delete the exclusions (assuming they end up merged) once you're ready to merge your own PR

Sounds good Chris!

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 1, 2022

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 172 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 19 files changed, 1083 insertions(+), 127 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 1, 2022

Tests analytics

Total tests: 2213
Passed tests 1968
Skipped tests: 240
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccContainerAzureCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeForwardingRule_update

@rileykarson rileykarson mentioned this pull request Nov 1, 2022
Closed
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Nov 1, 2022

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccContainerAzureCluster_BetaBasicHandWritten[Error message] [Debug log]
TestAccContainerAwsCluster_BetaBasicHandWritten[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath
melinath requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve test failures as described above

@ghabian ghabian mentioned this pull request Nov 3, 2022
Closed
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Nov 4, 2022

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 140 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 16 files changed, 737 insertions(+), 31 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 4, 2022

Tests analytics

Total tests: 2219
Passed tests 1977
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccContainerAwsCluster_BetaBasicHandWritten

@avinash84 avinash84 mentioned this pull request Nov 4, 2022
Closed
5 tasks
@modular-magician
Copy link
Collaborator

modular-magician commented Nov 4, 2022

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerAwsCluster_BetaBasicHandWritten[Debug log]

All tests passed
View the build log or the debug log for each test

@ghabian
Copy link
Contributor

ghabian commented Nov 4, 2022

@melinath Looks like we're all set now?

melinath
melinath approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath
Copy link
Member

melinath commented Nov 4, 2022

@rileykarson looks like you have to approve this as codeowner.

@ghabian
Copy link
Contributor

ghabian commented Nov 7, 2022

Thank you so much! @rileykarson if we could hold on cutting a release until my other PR (#6693) is merged as well (currently held up because of this one)

rileykarson
rileykarson approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I should take off the CODEOWNERS bit. That was to make sure we didn't inadvertently release some stuff & that window's passed.

@melinath melinath merged commit 9115a3e into GoogleCloudPlatform:main Nov 7, 2022
This was referenced Nov 7, 2022
Merged
Merged
Merged
@Monkeyanator Monkeyanator mentioned this pull request Nov 10, 2022
Merged
5 tasks
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
@alphanota @SirGitsalot
@ghabian @hao-nan-li
Upgrade the dcl version to v1.26.0 (GoogleCloudPlatform#6639)
af8f54f 
* Upgrade DCL to v1.23.0

* add clouddeploy test files

* upgrade dcl to v1.25

* upgrade dcl to v1.26

* delete extra samples folder. test executionTimeout field in run target json

* add tags, and monitoring_config

* Add monitoringConfig to other files

* Add a test for GKEHub servicemesh and exclude Eventarc trigger channel field

* remove monitoring_config in handwritten tests and adding exclude for field in beta

Co-authored-by: Chris Hawk <[email protected]>
Co-authored-by: Ghaleb Al-habian <[email protected]>
Co-authored-by: ghabian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath melinath approved these changes

@rileykarson rileykarson rileykarson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@alphanota @modular-magician @rileykarson @avinash84 @SirGitsalot @melinath @daveavi @ghabian