Skip to content

Conversation

@megan07
Copy link
Contributor

@megan07 megan07 commented May 3, 2022

Essentially reverts #4968
Adds certificate manager back in

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_certificate_manager_certificate`
`google_certificate_manager_dns_authorization`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 1908 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1908 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 278 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1999
Passed tests 1755
Skipped tests: 242
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample|TestAccCertificateManagerCertificate_certificateManagerCertificateBasicExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCertificateManagerCertificate_certificateManagerCertificateBasicExample[view]
TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample[view]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants