Move plugin version definitions to properties. #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a workaround for a missing feature in the codehaus versions maven plugin where is cannot update plugins directly, but it can detect when there are new plugins and update the related properties.
googlebot
added
the
cla: yes
Contributor
Author
|
@dpebot please merge when green |
Contributor
|
Okay! I'll merge when all statuses are green. |
|
|
||
| <properties> | ||
| <maven.compiler.target>1.6</maven.compiler.target> | ||
| <maven.compiler.source>1.6</maven.compiler.source> |
Contributor
Author
There was a problem hiding this comment.
/shruggie That's what it was. I was a bit surprised, too. I'll update that one, too.
Contributor
|
I'm generally happy with these changes, a few nits that can be ignored. |
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.3.8](https://www.github.com/googleapis/java-document-ai/compare/v0.3.7...v0.3.8) (2021-01-07) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.0 ([#300](https://www.github.com/googleapis/java-document-ai/issues/300)) ([7f96dc5](https://www.github.com/googleapis/java-document-ai/commit/7f96dc5a4b730ef7e8ed3e9010c4b6a1a15bbea0)) * update dependency com.google.cloud:google-cloud-storage to v1.113.8 ([#293](https://www.github.com/googleapis/java-document-ai/issues/293)) ([142c1cc](https://www.github.com/googleapis/java-document-ai/commit/142c1cce826257d4aa05d703ee0fdf72dd0130e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.3.8](https://www.github.com/googleapis/java-document-ai/compare/v0.3.7...v0.3.8) (2021-01-07) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.0 ([#300](https://www.github.com/googleapis/java-document-ai/issues/300)) ([7f96dc5](https://www.github.com/googleapis/java-document-ai/commit/7f96dc5a4b730ef7e8ed3e9010c4b6a1a15bbea0)) * update dependency com.google.cloud:google-cloud-storage to v1.113.8 ([#293](https://www.github.com/googleapis/java-document-ai/issues/293)) ([142c1cc](https://www.github.com/googleapis/java-document-ai/commit/142c1cce826257d4aa05d703ee0fdf72dd0130e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 16, 2022
* samples: add page management code samples * Lint Fix * Lint Fix * lint fix * lint fix * failing test fix * Failing Test Fix * change private to public for agentID * lint fix * lint fix * lint fix * Failing Test Fix * failing test fix * fix lint * called getName instead of name for page * Failing test fix * added parameters to variables * Added return type to create page * lint fix * Fixed failing test * Fix java failing tests * fix test * Test Fix * test fix * changed to afterall beforeall * Changed before and after all * Lint fix * test fail fix * lint fix * chagned stdout to static * failing test fix * added stdout setup * removed loop * updated list tests * lint fix * moved stdout * Added return type to listpage * lint fix * changed list test * update test * lint fix * lint fix * Fix testListPage * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revised code per comments * Lint fix * CreateSimplePage builder import fix * CreateSimplePage test fix * moved region tags * Revised code per commments * lint fix * Returned response * changed testListPage * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed results string Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
* samples: add page management code samples * Lint Fix * Lint Fix * lint fix * lint fix * failing test fix * Failing Test Fix * change private to public for agentID * lint fix * lint fix * lint fix * Failing Test Fix * failing test fix * fix lint * called getName instead of name for page * Failing test fix * added parameters to variables * Added return type to create page * lint fix * Fixed failing test * Fix java failing tests * fix test * Test Fix * test fix * changed to afterall beforeall * Changed before and after all * Lint fix * test fail fix * lint fix * chagned stdout to static * failing test fix * added stdout setup * removed loop * updated list tests * lint fix * moved stdout * Added return type to listpage * lint fix * changed list test * update test * lint fix * lint fix * Fix testListPage * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revised code per comments * Lint fix * CreateSimplePage builder import fix * CreateSimplePage test fix * moved region tags * Revised code per commments * lint fix * Returned response * changed testListPage * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed results string Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a workaround for a missing feature in the codehaus versions maven
plugin where is cannot update plugins directly, but it can detect when
there are new plugins and update the related properties. mojohaus/versions#8 (comment)
I don't actually update anything (or I tried not to, anyway). I'll get dpebot to do that.
@lesv