Conversation
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Sample spanner_quickstart is a basic program that uses Cloud Spanner. | ||
| // [START spanner_quickstart] |
There was a problem hiding this comment.
Please move this above the doc comment, or below it. As it is, it'll be included in package docs.
| } | ||
| fmt.Fprintf(w, "Created database [%s]\n", db) | ||
| return nil | ||
| // [END spanner_create_database] |
There was a problem hiding this comment.
Move the end tags above the final return statement.
|
Please run gofmt over the CL after the comments are addressed. Something like this, maybe, if you don't have Go installed: |
|
Done |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
3 participants
Related:
Clean up Spanner region tags. googleapis/nodejs-spanner#136mergedClean up Spanner region tags. ruby-docs-samples#244mergedAdd Spanner region tags. python-docs-samples#1376mergedClean up Spanner region tags. java-docs-samples#1045mergedClean up Spanner region tags. php-docs-samples#562merged