Skip to content

feat(storage): update dual-region sample using CustomPlacementConfig#2620

Merged
gcf-merge-on-green[bot] merged 7 commits intoGoogleCloudPlatform:mainfrom
cojenco:cdr-2582
Jul 22, 2022
Merged

feat(storage): update dual-region sample using CustomPlacementConfig#2620
gcf-merge-on-green[bot] merged 7 commits intoGoogleCloudPlatform:mainfrom
cojenco:cdr-2582

Conversation

@cojenco
Copy link
Copy Markdown
Contributor

@cojenco cojenco commented Jul 1, 2022 •
edited
Loading

Fixes #2582
Fixes #2644

Tests pending googleapis/google-cloud-go#6294 along with new library release

@cojenco cojenco requested review from a team as code owners July 1, 2022 18:12
@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Jul 1, 2022
@cojenco cojenco requested review from danielbankhead and tritone July 1, 2022 18:12
@enocom
Copy link
Copy Markdown
Member

enocom commented Jul 6, 2022

@cojenco does this PR need a new library version before it's ready for review?

@cojenco
Copy link
Copy Markdown
Contributor Author

cojenco commented Jul 11, 2022

@cojenco does this PR need a new library version before it's ready for review?

Yep this PR requires a new library release once the feature changes are merged in, thanks!

@tritone tritone self-assigned this Jul 12, 2022
@tritone tritone added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2022
tritone
tritone reviewed Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM once we merge the library feature and update.

Comment thread storage/buckets/create_bucket_dual_region.go Outdated
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 20, 2022
tritone added a commit to tritone/golang-samples that referenced this pull request Jul 20, 2022
@tritone
test(storage): Skip dual region test
4936d70 
This test is failing due to the rollout of a backend change.
It should be fixed and re-enabled in GoogleCloudPlatform#2620.

Updates GoogleCloudPlatform#2644
@tritone tritone mentioned this pull request Jul 20, 2022
Merged
tritone added a commit that referenced this pull request Jul 20, 2022
@tritone
test(storage): Skip dual region test (#2645)
a9c8603 
This test is failing due to the rollout of a backend change.
It should be fixed and re-enabled in #2620.

Updates #2644
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 7f1d578 into GoogleCloudPlatform:main Jul 22, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tritone tritone tritone approved these changes

@danielbankhead danielbankhead Awaiting requested review from danielbankhead

Assignees

@tritone tritone

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage/buckets: TestCreateBucketDualRegion failed refactor(storage): Dual-Region Sample for Updated API

4 participants

@cojenco @enocom @tritone @kokoro-team