Skip to content

docs(mcp-imagen-go): add deprecation banner and DEPRECATION.md audit - #1912

Merged
ghchinoy merged 1 commit into
GoogleCloudPlatform:mainfrom
marrionesa:chore/deprecate-mcp-imagen-go-refs
Oct 17, 2026
Merged

ghchinoy merged 1 commit into
GoogleCloudPlatform:mainfrom
marrionesa:chore/deprecate-mcp-imagen-go-refs

Conversation

@marrionesa

Copy link
Copy Markdown
Contributor

What

Closes the documentation scope of issue #1588 by:

  1. Adding a deprecation banner to the top of mcp-imagen-go/README.md
    pointing users at mcp-nanobanana-go / mcp-gemini-go.
  2. Adding mcp-imagen-go/DEPRECATION.md with the full audit of remaining
    mcp-imagen-go / imagen_t2i references — in-tree
    (experiments/mcp-genmedia/) and repo-wide — each hit classified, the
    framed open decision the issue raises, and re-runnable grep commands.

Documentation-only, no code changes. References #1588.

What's already landed

The content changes of commit dc48d1f6 (the one relevant commit carried
by the closed draft PR #1245) are already present on main: the sample
gemini-extension.json files and sample_settings.json, the
install.sh / deploy-cloudrun.sh exclusions, and the genkit/adk sample
updates. I verified this by cherry-picking dc48d1f6 onto current main
— it conflicts in four files purely on context drift, and resolving those
by keeping main's version yields a zero net diff.

Audit conclusion

  • Inside experiments/mcp-genmedia/: no stale user-facing references
    remain
    . Every hit is the enforcement itself, an immutable changelog
    entry, an in-tree implementation/build file, or a historical/comparison
    comment (DEPRECATION.md §3, 21 rows).
  • Repo-wide (§3.1, 10 more files): the hand-maintained docs-site still
    routes new users to mcp-imagen-go in three places (an ADK setup
    instruction, a Gemini-CLI example settings block registering an
    "imagen" server, and a generic run example), and the published
    mcp-imagen-go page has no deprecation notice. I flagged those as
    candidates for cleanup — happy to follow up with that docs-site swap
    PR, of the same kind dc48d1f6 already did in-tree. Two CI entries
    (build loop + publish matrix) still include mcp-imagen-go; consistent
    while the directory stays, and they should travel with the removal PR
    whenever the directory goes.

Open decision

Issue #1588 asks whether to keep references-only deprecation or also
remove the mcp-imagen-go directory. Per the 2026-08-22 inventory
comment and the same-day correction on #1588 (verified live on Vertex AI
with gemini-3.1-flash-image), the core-app /imagen-upscale and
Virtual Try-On surfaces do have practical Nano Banana approximations,
but they are not drop-in replacements (upscale is a re-generation, not a
faithful super-resolution; VTO is not catalog-grade). DEPRECATION.md §4
therefore recommends keeping the directory in-tree until you decide
whether those approximations are acceptable; the removal, when agreed,
is a single mechanical follow-up PR, and the audit lists everything that
would need to travel with it.

How to verify

grep -rln 'mcp-imagen-go\|imagen_t2i\|mcp_imagen' \
    experiments/mcp-genmedia/ \
    --include='*.md' --include='*.json' --include='*.py' \
    --include='*.js' --include='*.ts' --include='*.go' \
    --include='*.sh' --include='*.yaml' --include='*.yml'

git grep -lE 'mcp-imagen-go|imagen_t2i|mcp_imagen'

Each hit should match a row in DEPRECATION.md §3 / §3.1. (Note: use GNU
grep; ripgrep users need --no-ignore because the repo's .gitignore
rule **/mcp-*-go/mcp-*-go hides those tracked files.)

Notes

  • Documentation-only PR, no code changes.
  • I signed the Google CLA.
  • Happy to follow up with (a) the docs-site reference swaps from §3.1
    and/or (b) the directory-removal PR once the upscale/VTO migration
    path is agreed.

References #1588.

Issue GoogleCloudPlatform#1588 asks for two things: (1) documentation + sample-config
reference swaps imagen -> nanobanana/gemini, and (2) an audit of any
remaining imagen references. The content changes of commit dc48d1f
(closed draft PR GoogleCloudPlatform#1245) are already present on main: cherry-picking it
onto main conflicts only on context drift in four files, and resolving
those by keeping main's version yields a zero net diff. This PR closes
the loop on (2) and frames the open decision the issue explicitly raises.

Changes (documentation only, no code changes):
- mcp-imagen-go/README.md: add a deprecation banner at the top pointing
  users at mcp-nanobanana-go / mcp-gemini-go and at the new DEPRECATION.md.
- mcp-imagen-go/DEPRECATION.md: full audit of remaining mcp-imagen-go /
  imagen_t2i references, split into the in-tree sweep
  (experiments/mcp-genmedia/, all hits acceptable) and a repo-wide sweep
  that flags the hand-maintained docs-site pages still routing new users
  to mcp-imagen-go (candidates for cleanup, offered as follow-up work),
  plus the CI entries that still build and publish the server.

The DEPRECATION.md also frames the issue's open decision
(references-only vs. remove the server directory): it cites the
maintainer's 2026-08-22 inventory comment and the same-day correction
verifying that the upscale and VTO surfaces do have practical Nano
Banana approximations that are not drop-in replacements, and recommends
keeping the directory in-tree until the maintainer decides on the
migration path. Either way, removal is a single mechanical follow-up PR.

References GoogleCloudPlatform#1588.
@ghchinoy
ghchinoy merged commit b9cd544 into GoogleCloudPlatform:main Oct 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants