Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Feb 20, 2021

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2021
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #290 (2d43a5d) into main (3b55fce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          87       87           
  Lines        2255     2255           
=======================================
  Hits         1997     1997           
  Misses        258      258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b55fce...2d43a5d. Read the comment docs.

Just a single static build for now, enough to verify we are not breaking
vcpkg and that the framework compiles. It uses
`FUNCTIONS_FRAMEWORK_CPP_TEST_EXAMPLES=OFF` to reduce the build times,
mostly that avoids `gRPC`, `protobuf`, and `google-cloud-cpp`.
@coryan coryan marked this pull request as ready for review February 20, 2021 18:28
@coryan coryan requested a review from a team as a code owner February 20, 2021 18:28
@coryan coryan merged commit 274ce48 into GoogleCloudPlatform:main Feb 20, 2021
@coryan coryan deleted the ci-create-build-for-msvc branch February 20, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants