Skip to content

Update the TFLint Google ruleset version to 0.30.0#5401

Merged
SwarnaBharathiMantena merged 2 commits into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update_tflint_version
Mar 25, 2026
Merged

Update the TFLint Google ruleset version to 0.30.0#5401
SwarnaBharathiMantena merged 2 commits into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update_tflint_version

Conversation

@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena SwarnaBharathiMantena commented Mar 25, 2026

The TFLint version needs to be updated to allow the use of gen4 machines like the N4 machines in the machine_type defaults.

Error encountered:

Terraform validate with tflint...........................................Failed
- hook id: terraform_tflint
- exit code: 2

Command 'tflint --init' successfully done:
Plugin "google" is already installed
Plugin "terraform" is already installed



TFLint in modules/scheduler/gke-cluster/:
1 issue(s) found:

Error: "n4-standard-4" is an invalid as machine type (google_container_node_pool_invalid_machine_type)

  on main.tf line 354:
 354:     machine_type    = var.system_node_pool_machine_type

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-bugfix Added to release notes under the "Bug fixes" heading. label Mar 25, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 25, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TFLint Google ruleset to version 0.30.0. This update is essential for resolving a validation error that occurred when attempting to use newer generation machine types, such as N4 machines, in Terraform configurations. By upgrading the ruleset, the linter will correctly recognize and validate these modern machine types, enabling their seamless integration into deployments.

Highlights

  • TFLint Google Ruleset Update: Updated the tflint-ruleset-google plugin version from 0.26.0 to 0.30.0 in the .tflint.hcl configuration. This resolves a validation error that previously prevented the use of newer machine types, such as n4-standard-4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the google plugin for tflint from "0.26.0" to "0.30.0". I have no feedback to provide.

@SwarnaBharathiMantena SwarnaBharathiMantena enabled auto-merge (squash) March 25, 2026 11:41
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit d876a1f into GoogleCloudPlatform:develop Mar 25, 2026
12 of 68 checks passed
FIoannides pushed a commit to FIoannides/cluster-toolkit that referenced this pull request Mar 27, 2026
@SwarnaBharathiMantena @FIoannides
Update the TFLint Google ruleset version to 0.30.0 (GoogleCloudPlatfo…
d2e45ba 
…rm#5401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@shubpal07 shubpal07 shubpal07 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwarnaBharathiMantena @vikramvs-gg @shubpal07