Binary dependencies downloading script by scaliby · Pull Request #5354 · GoogleCloudPlatform/cluster-toolkit

scaliby · 2026-03-13T09:47:35Z

Submission Checklist

Adds functionality of auto downloading binary dependencies on CTK launch.

gemini-code-assist · 2026-03-13T09:47:47Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an automated system for managing and verifying the integrity of critical external binary dependencies, specifically Terraform and Packer. By adding a script that fetches and embeds official checksums into the codebase, it establishes a robust method to ensure that only trusted versions of these tools are utilized, thereby enhancing the overall security posture and reliability of the project.

Highlights

New Dependency Management Script: A new Bash script, tools/update-dependencies.sh, has been introduced to automate the process of fetching and updating checksums for external binary dependencies.
Automated Checksum Generation: The script downloads SHA256 checksums for specified versions of Terraform and Packer from their official release pages.
Generated Go Checksum File: The fetched checksums are then used to generate a Go source file, pkg/dependencies/checksums_generated.go, which contains the expected checksums and version numbers for these tools.
Enhanced Security and Integrity: This mechanism ensures that the application uses verified versions of Terraform and Packer, improving security and integrity by preventing the use of tampered or incorrect binaries.

Changelog

pkg/dependencies/checksums_generated.go
- Added a new Go file that is automatically generated to store the SHA256 checksums and version numbers for Terraform and Packer binaries.
tools/update-dependencies.sh
- Added a new Bash script responsible for fetching the latest SHA256 checksums for Terraform and Packer from their release pages.
- Implemented logic within the script to parse the downloaded checksums and dynamically generate the pkg/dependencies/checksums_generated.go file.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a shell script to automatically download and update checksums for Terraform and Packer, storing them in a generated Go file. The implementation is functional, but the script contains duplicated code for handling each dependency. I've suggested refactoring it to use a function, which will improve maintainability and make it easier to add more dependencies in the future, in line with the repository's style guide.

tools/update-dependencies.sh

siddhartha-quad · 2026-03-13T10:26:49Z

/gcbrun

gcluster.go

CONTRIBUTING.md

pkg/dependencies/downloader.go

pkg/dependencies/resolver.go

README.md

bytetwin · 2026-03-17T10:00:00Z

/gcbrun

Neelabh94 · 2026-03-17T10:49:29Z

@scaliby could you please look at the pre-commit failures and resolve them.

scaliby · 2026-03-17T11:52:10Z

@Neelabh94 should be good now

Neelabh94 · 2026-03-17T11:56:05Z

@Neelabh94 should be good now

re-running the tests

Neelabh94 · 2026-03-17T11:57:26Z

/gcbrun

Neelabh94 · 2026-03-17T12:40:52Z

@scaliby few tests were still failing due to Go version mismatch that was recently fixed in the develop branch.

Have rebased with the develop branch and re-ran the tests. Should pass now.

Neelabh94 · 2026-03-17T12:40:58Z

/gcbrun

scaliby · 2026-03-17T12:50:59Z

@Neelabh94 rebased on top of the latest develop

Neelabh94 · 2026-03-17T12:54:48Z

@scaliby The integration test is failing due to insufficient Go test coverage in the hpc-toolkit/pkg/dependencies package (15.2% instead of the required 80%).

scaliby · 2026-03-17T12:57:07Z

@Neelabh94 I added more tests. Could you re-run it?

Neelabh94 · 2026-03-17T13:38:37Z

/gcbrun

Neelabh94 · 2026-03-17T14:46:21Z

@bytetwin could you please review once again.

scaliby · 2026-03-17T16:21:31Z

@bytetwin @Neelabh94 I don't have permissions for merging. Could you please merge?

github-actions bot added the external PR from external contributor label Mar 13, 2026

gemini-code-assist bot reviewed Mar 13, 2026

View reviewed changes

tools/update-dependencies.sh Outdated Show resolved Hide resolved

scaliby force-pushed the dep-checksum-script branch from d2eabf9 to b0ef800 Compare March 13, 2026 09:53

scaliby marked this pull request as ready for review March 13, 2026 09:53

scaliby requested review from a team and samskillman as code owners March 13, 2026 09:53

scaliby force-pushed the dep-checksum-script branch from b0ef800 to e5ae788 Compare March 13, 2026 10:48

mufaqam-gcl requested review from Neelabh94 and SwarnaBharathiMantena March 13, 2026 12:53

scaliby force-pushed the dep-checksum-script branch from e5ae788 to 63addd9 Compare March 13, 2026 13:02

Neelabh94 previously approved these changes Mar 13, 2026

View reviewed changes

scaliby dismissed Neelabh94’s stale review via 406c38a March 13, 2026 14:26

scaliby force-pushed the dep-checksum-script branch from 63addd9 to 406c38a Compare March 13, 2026 14:26

scaliby requested a review from Neelabh94 March 13, 2026 14:27

scaliby changed the title ~~Binary dependencies checksum downloading script~~ Binary dependencies downloading script Mar 16, 2026

bytetwin reviewed Mar 17, 2026

View reviewed changes

scaliby requested a review from bytetwin March 17, 2026 08:35

bytetwin requested changes Mar 17, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

bytetwin added the enhancement New feature or request label Mar 17, 2026

scaliby requested a review from bytetwin March 17, 2026 10:08

bytetwin previously approved these changes Mar 17, 2026

View reviewed changes

Neelabh94 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 17, 2026

scaliby dismissed bytetwin’s stale review via 26ccdcb March 17, 2026 11:38

scaliby requested a review from bytetwin March 17, 2026 11:52

Neelabh94 force-pushed the dep-checksum-script branch from 26ccdcb to 4570b0e Compare March 17, 2026 12:37

scaliby force-pushed the dep-checksum-script branch from 4570b0e to afc04ec Compare March 17, 2026 12:50

scaliby added 10 commits March 17, 2026 12:50

feat: add script downloading dependencies checksums

58d3c93

update docs

551c02a

feat: add logic for downloading dependencies

0190c4a

feat: instrumentate path patching

a30d4ff

feat: orchiestrate dependencies download

8694bf8

docs: update docs with --download-depencies flags

ae186e5

address peer review changes

9fd9445

address peer review changes

8adcf6a

reformat

8bf1a1a

increase coverage

cc2f9dc

scaliby force-pushed the dep-checksum-script branch from afc04ec to cc2f9dc Compare March 17, 2026 12:50

Neelabh94 approved these changes Mar 17, 2026

View reviewed changes

bytetwin approved these changes Mar 17, 2026

View reviewed changes

LAVEEN approved these changes Mar 17, 2026

View reviewed changes

Neelabh94 merged commit 1cca13e into GoogleCloudPlatform:develop Mar 17, 2026
13 of 77 checks passed

Neelabh94 pushed a commit to Neelabh94/cluster-toolkit that referenced this pull request Mar 18, 2026

Add Binary dependencies downloading script (GoogleCloudPlatform#5354)

82a6f69

Conversation

scaliby commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Checklist

Uh oh!

gemini-code-assist bot commented Mar 13, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

siddhartha-quad commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bytetwin commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

scaliby commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

scaliby commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

scaliby commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026

Uh oh!

Neelabh94 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scaliby commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

scaliby commented Mar 13, 2026 •

edited

Loading

Neelabh94 commented Mar 17, 2026 •

edited

Loading

Neelabh94 commented Mar 17, 2026 •

edited

Loading