Skip to content

Update cloud_dns_config to default to KUBE_DNS (CoreDNS)#5336

Merged
SwarnaBharathiMantena merged 6 commits intoGoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update_dns_config
Mar 17, 2026
Merged

Update cloud_dns_config to default to KUBE_DNS (CoreDNS)#5336
SwarnaBharathiMantena merged 6 commits intoGoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update_dns_config

Conversation

@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena SwarnaBharathiMantena commented Mar 11, 2026 •
edited
Loading

Update cloud_dns_config to default to KUBE_DNS

  • Changed the default cluster_dns provider from PROVIDER_UNSPECIFIED to KUBE_DNS in the gke-cluster module.
  • Updated the variable description to correctly reflect KUBE_DNS as the default option which maps to CoreDNS on GKE 1.21+.

@SwarnaBharathiMantena
Update cloud_dns_config to default to KUBE_DNS
c10e95d 
- Changed the default cluster_dns provider from PROVIDER_UNSPECIFIED to KUBE_DNS in the gke-cluster module.
- Updated the variable description to correctly reflect KUBE_DNS as the default option which maps to CoreDNS on GKE 1.21+.
@SwarnaBharathiMantena SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Mar 11, 2026
@SwarnaBharathiMantena SwarnaBharathiMantena requested a review from a team as a code owner March 11, 2026 07:23
@SwarnaBharathiMantena SwarnaBharathiMantena added the release-breaking-changes Prevents "smooth" re-deploy across versions label Mar 11, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 11, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines GKE cluster configurations by aligning default DNS settings with modern practices and enabling a key networking feature by default. It ensures that new clusters leverage KUBE_DNS (CoreDNS) for in-cluster DNS resolution and automatically enable the external DNS endpoint for control plane access, simplifying setup and improving out-of-the-box functionality.

Highlights

  • Default DNS Provider: The default cluster_dns provider in cloud_dns_config has been updated from PROVIDER_UNSPECIFIED to KUBE_DNS (CoreDNS) for GKE clusters.
  • External DNS Endpoint: The default value for enable_external_dns_endpoint has been changed from false to true.
Changelog
  • modules/scheduler/gke-cluster/variables.tf
    • Updated the description for the cloud_dns_config variable to reflect KUBE_DNS as the new default for cluster_dns.
    • Modified the default value of cloud_dns_config.cluster_dns from PROVIDER_UNSPECIFIED to KUBE_DNS.
    • Extended the validation condition for cloud_dns_config.cluster_dns to include KUBE_DNS as a valid option.
    • Changed the default value of enable_external_dns_endpoint from false to true.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default DNS configuration for GKE clusters to use KUBE_DNS and enables the external DNS endpoint by default. However, enabling the external DNS endpoint by default significantly increases the attack surface of the GKE control plane by exposing a public DNS record and potentially a public IP, even for clusters intended to be private. It is recommended to maintain a 'secure by default' approach by keeping this feature disabled unless explicitly requested. Additionally, please improve the validation logic for cloud_dns_config.cluster_dns by using the contains function for better readability and maintainability, and ensure the module's README.md is updated to reflect these new default values.

@SwarnaBharathiMantena SwarnaBharathiMantena changed the title Update cloud_dns_config to default to KUBE_DNS (CoreDNS) and set enable_external_dns_endpoint to true Update cloud_dns_config to default to KUBE_DNS (CoreDNS) Mar 12, 2026
@SwarnaBharathiMantena SwarnaBharathiMantena requested review from cboneti and removed request for stony-tark March 16, 2026 10:03
@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor Author

SwarnaBharathiMantena commented Mar 17, 2026

SUCCESS PR-test-gke go/ghpc-cb/a54865b9-6fba-422a-9eb9-1bd860707f29
SUCCESS PR-test-gke-a2-highgpu-kueue-onspot go/ghpc-cb/447e6576-1476-4611-a671-3d089b0c38be
SUCCESS[2] PR-test-gke-a3-highgpu go/ghpc-cb/1a96af78-859e-423f-a632-eee345cbb490
SUCCESS PR-test-gke-a3-highgpu-onspot go/ghpc-cb/dcc8110e-98bc-438d-a8a1-4b354d89390f
SUCCESS PR-test-gke-a3-megagpu go/ghpc-cb/b9b6d582-8286-4f02-ac07-fa7293503282
SUCCESS PR-test-gke-a3-megagpu-onspot go/ghpc-cb/90295107-d77a-4f86-b683-42db05cb0bb5
SUCCESS PR-test-gke-a3-ultragpu-onspot go/ghpc-cb/0b625ea4-6df7-45bc-a7f1-1a9a477bf88b
SUCCESS[2] PR-test-gke-a4-onspot go/ghpc-cb/dcc29348-5c18-498a-885d-2c988760227e
SUCCESS PR-test-gke-g4 go/ghpc-cb/9f288be9-ad03-435b-8d99-da747fefd230
SUCCESS PR-test-gke-h4d go/ghpc-cb/d59df2c3-19d7-4688-b54c-f6ebf2e2a6e1
SUCCESS PR-test-gke-h4d-onspot go/ghpc-cb/89069190-e48e-4368-b877-6cf8a00aad4a
SUCCESS PR-test-gke-inactive-reservation go/ghpc-cb/49062c01-7da4-4333-b724-03e7ae0137b6
SUCCESS PR-test-gke-managed-hyperdisk go/ghpc-cb/1e6725df-4189-447f-9ddc-49b5425e9de9
SUCCESS PR-test-gke-managed-lustre go/ghpc-cb/d6b59232-d619-4a54-80f8-3cbaa3b402b6
SUCCESS PR-test-gke-storage go/ghpc-cb/4b9aaa40-4026-4862-9e16-42cfebef4927
SUCCESS PR-test-gke-tpu-7x go/ghpc-cb/3cb2c981-480a-4a72-a58d-bd6b692a79ed
SUCCESS PR-test-gke-tpu-v6e go/ghpc-cb/133397db-0588-4a6b-a658-c7bfdf8816fe
SUCCESS PR-test-ml-gke go/ghpc-cb/4b5e9b28-c769-45e1-bcb5-97d54f1ef3b2
SUCCESS PR-test-ml-gke-e2e go/ghpc-cb/3c0e5fec-c5e2-4a8a-820e-ea9249518751
SUCCESS PR-test-slurm-gke go/ghpc-cb/ad0f64cd-6e36-4d7e-bfd1-f8363fef6d67
FAILURE[2] PR-test-gke-tpu-v6e-flex go/ghpc-cb/865c68c5-394f-42dc-905d-9416364cd2b9
------- TOTAL:21 | SUCCESS: 20 | FAILURE: 1

@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 1d4a735 into GoogleCloudPlatform:develop Mar 17, 2026
12 of 74 checks passed
Neelabh94 pushed a commit to Neelabh94/cluster-toolkit that referenced this pull request Mar 18, 2026
@SwarnaBharathiMantena @Neelabh94
Update cloud_dns_config to default to KUBE_DNS (CoreDNS) (GoogleCloud…
6669561 
…Platform#5336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

@cboneti cboneti Awaiting requested review from cboneti

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@stony-tark stony-tark stony-tark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwarnaBharathiMantena @Neelabh94 @stony-tark