Skip to content

Hardcode zone in a2high PR test to fix test failures#5305

Merged
kadupoornima merged 1 commit intoGoogleCloudPlatform:release-candidatefrom
kadupoornima:release-candidate
Mar 2, 2026
Merged

Hardcode zone in a2high PR test to fix test failures#5305
kadupoornima merged 1 commit intoGoogleCloudPlatform:release-candidatefrom
kadupoornima:release-candidate

Conversation

@kadupoornima
Copy link
Copy Markdown
Contributor

Hardcode zone in a2-highgpu-kueue-onspot PR test to us-central1-b to fix test failures that have been occurring due to GCE_STOCKOUT (insufficient capacity) in the zone that was being dynamically selected. This is a hotfix, we will be needing to look into the dynamic selection logic to understand why a wrong zone was suggested in the first place.

@kadupoornima kadupoornima requested review from a team and samskillman as code owners March 2, 2026 15:52
@kadupoornima kadupoornima added the release-bugfix Added to release notes under the "Bug fixes" heading. label Mar 2, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a hotfix to address persistent test failures in the a2-highgpu-kueue-onspot PR test. The failures were attributed to GCE_STOCKOUT issues arising from dynamically selected zones. By hardcoding the test zone to us-central1-b and explicitly setting the provisioning model to SPOT, the changes aim to stabilize the test suite and ensure reliable execution. Further investigation into the dynamic zone selection logic is planned.

Highlights

  • Test Stability: Hardcoded the Google Cloud zone to "us-central1-b" in the a2-highgpu-kueue-onspot PR test to prevent GCE_STOCKOUT failures.
  • Configuration Update: Explicitly set the PROVISIONING_MODEL to SPOT in the test configuration.
  • Dynamic Zone Selection: Disabled the dynamic zone selection script, which was previously responsible for determining the test zone.
Changelog
  • tools/cloud-build/daily-tests/builds/gke-a2-highgpu-kueue-onspot.yaml
    • Added ZONE and PROVISIONING_MODEL environment variables with hardcoded values.
    • Commented out the shell script logic responsible for dynamically determining the ZONE.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies a hotfix to address test failures in the a2-highgpu-kueue-onspot test caused by GCE_STOCKOUT errors. The fix involves hardcoding the zone to us-central1-b and disabling the dynamic zone selection logic. This is a reasonable temporary measure.

@kadupoornima kadupoornima merged commit 44196de into GoogleCloudPlatform:release-candidate Mar 2, 2026
13 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants