Make waiting for kueue installation configurable, and wait for kueue in the G4 GKE blueprint#4973
Conversation
Summary of ChangesHello @kadupoornima, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GKE G4 blueprint by introducing a configurable 'wait' option for Kueue installations. This ensures that the deployment workflow can reliably depend on Kueue being fully operational before proceeding with subsequent steps. Additionally, it provides concrete example values for the GKE G4 deployment configuration, which will aid in quicker setup and validation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a wait=true option for the Kueue installation, ensuring that subsequent steps only proceed after Kueue is fully ready. The implementation correctly adds the wait parameter to the kueue variable, passes it to the Helm installation module, and updates the example blueprint. My review includes feedback on improving documentation for the new parameter and addressing a security concern and hardcoded values in the example deployment file.
kadupoornima
changed the title
wait=true for kueue installation in G4 GKE blueprint.
kadupoornima
changed the title
wait=true for kueue installation in G4 GKE blueprint.
kadupoornima
added
the
release-bugfix
kadupoornima
force-pushed
the
kueue
branch
3 times, most recently
from
d370a32 to
9cde6ce
Compare
kadupoornima
added
release-improvements
kadupoornima
force-pushed
the
kueue
branch
2 times, most recently
from
d14e334 to
f6cdfc5
Compare
kadupoornima
changed the title
kadupoornima
changed the title
SwarnaBharathiMantena
left a comment
SwarnaBharathiMantena
left a comment
There was a problem hiding this comment.
I think, ideally we should keep the actual terraform module default same on our end too.
The default is True on the actual terraform module - https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release#wait-1
Due to some testing results earlier, we set the default to False. In case we see value in it, we can reset it in future.
kadupoornima
merged commit 167c1d0
into
GoogleCloudPlatform:develop
2 participants
Made the
waitparameter in kueue installation configurable. Updated the GKE G4 blueprint to explicitly setwait: truefor Kueue installation, allowing the deployment process to pause until Kueue is fully ready.GKE G4 daily test was failing when attempting to submit a Kubernetes job, specifically encountering an
Internal Server Error (HTTP 500)caused by a broken admission webhook. The test had succeeded after 1 retry attempt.This PR fixes the probable root cause.
Manual cluster creation and deletion were successfully tested with this change.