Skip to content

Update vpc and cloud_router versions in VPC network module#4732

Merged
kadupoornima merged 1 commit into
GoogleCloudPlatform:developfrom
kadupoornima:version
Oct 7, 2025
Merged

Update vpc and cloud_router versions in VPC network module#4732
kadupoornima merged 1 commit into
GoogleCloudPlatform:developfrom
kadupoornima:version

Conversation

@kadupoornima
Copy link
Copy Markdown
Contributor

@kadupoornima kadupoornima commented Oct 7, 2025

Update vpc and cloud_router versions in VPC network module to be able to use >=7.2 terraform google provider version.

The older versions restrain the TF google provider version to be <7.0, which is causing issues in being able to use the newer versions.

Before the change:

user@w-kadupoornima-mct8nk3p:~/cluster-toolkit-2/modules/network/vpc$ terraform providers

Providers required by configuration:
.
├── provider[terraform.io/builtin/terraform]
├── module.nat_ip_addresses
│   └── provider[registry.terraform.io/hashicorp/google] >= 5.2.0, < 8.0.0
├── module.vpc
│   ├── provider[registry.terraform.io/hashicorp/google] >= 4.64.0, < 7.0.0
│   ├── provider[registry.terraform.io/hashicorp/google-beta] >= 4.64.0, < 7.0.0
│   ├── module.routes
│       └── provider[registry.terraform.io/hashicorp/google] >= 3.83.0, < 7.0.0
│   ├── module.subnets
│       └── provider[registry.terraform.io/hashicorp/google] >= 4.25.0, < 7.0.0
│   ├── module.vpc
│       ├── provider[registry.terraform.io/hashicorp/google] >= 4.64.0, < 7.0.0
│       └── provider[registry.terraform.io/hashicorp/google-beta] >= 6.13.0, < 7.0.0
│   └── module.firewall_rules
│       └── provider[registry.terraform.io/hashicorp/google] >= 3.33.0, < 7.0.0
└── module.cloud_router
    └── provider[registry.terraform.io/hashicorp/google] >= 4.51.0, < 7.0.0

After the change:

user@w-kadupoornima-mct8nk3p:~/cluster-toolkit-2/modules/network/vpc$ terraform providers

Providers required by configuration:
.
├── provider[terraform.io/builtin/terraform]
├── module.nat_ip_addresses
│   └── provider[registry.terraform.io/hashicorp/google] >= 5.2.0, < 8.0.0
├── module.vpc
│   ├── provider[registry.terraform.io/hashicorp/google-beta] >= 4.64.0, < 8.0.0
│   ├── provider[registry.terraform.io/hashicorp/google] >= 4.64.0, < 8.0.0
│   ├── module.routes
│       └── provider[registry.terraform.io/hashicorp/google] >= 3.83.0, < 8.0.0
│   ├── module.subnets
│       └── provider[registry.terraform.io/hashicorp/google] >= 4.25.0, < 8.0.0
│   ├── module.vpc
│       ├── provider[registry.terraform.io/hashicorp/google] >= 6.19.0, < 8.0.0
│       └── provider[registry.terraform.io/hashicorp/google-beta] >= 6.19.0, < 8.0.0
│   └── module.firewall_rules
│       └── provider[registry.terraform.io/hashicorp/google] >= 3.33.0, < 8.0.0
└── module.cloud_router
    └── provider[registry.terraform.io/hashicorp/google] >= 4.51.0, < 8.0.0

@kadupoornima
Update vpc and cloud_router versions in VPC network module to be able…
fe35216 
… to use >=7.2 terraform google provider version.
@kadupoornima kadupoornima requested review from a team and samskillman as code owners October 7, 2025 10:09
@kadupoornima kadupoornima added the release-breaking-changes Prevents "smooth" re-deploy across versions label Oct 7, 2025
@bytetwin
Copy link
Copy Markdown
Collaborator

bytetwin commented Oct 7, 2025

/gcbrun

bytetwin
bytetwin approved these changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bytetwin bytetwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you trigger some tests (have triggered /gcbrun) before merging

@kadupoornima
Copy link
Copy Markdown
Contributor Author

kadupoornima commented Oct 7, 2025

LGTM. Can you trigger some tests (have triggered /gcbrun) before merging

Thanks. Using the babysit tool to run all the tests.

@kadupoornima kadupoornima merged commit 409de5b into GoogleCloudPlatform:develop Oct 7, 2025
38 of 64 checks passed
@kadupoornima kadupoornima deleted the version branch October 7, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bytetwin bytetwin bytetwin approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

@samskillman samskillman Awaiting requested review from samskillman

Assignees

No one assigned

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @bytetwin